From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6CE472CC88
	for <tarantool-patches@freelists.org>; Thu, 16 May 2019 19:12:32 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id IaqDUu8MlcdD for <tarantool-patches@freelists.org>;
	Thu, 16 May 2019 19:12:32 -0400 (EDT)
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 25CD62C919
	for <tarantool-patches@freelists.org>; Thu, 16 May 2019 19:12:32 -0400 (EDT)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v1 2/3] sql: ban sql functions
 coinciding with builtins
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <068d058c4b8354f332e67e95761f722ab72cbae0.1557941573.git.kshcherbatov@tarantool.org>
Date: Fri, 17 May 2019 02:12:29 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <0356C5B8-C1B1-4986-BBC7-5202E877F656@tarantool.org>
References: <cover.1557941573.git.kshcherbatov@tarantool.org>
 <068d058c4b8354f332e67e95761f722ab72cbae0.1557941573.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>



> On 15 May 2019, at 20:34, Kirill Shcherbatov =
<kshcherbatov@tarantool.org> wrote:
>=20
> Previously, it was possible to create a function with name
> that is already reserved for some predefined builtin.
> It is a bug. This patch bans sql_create_function for such cases.
>=20
> Also removed FUNC_PERFECT_MATCH user session flag.
>=20
> Closes #4219
> Needed for #3691

Could you please split this patch into two: first one would
provide only code style fixes and the second one - functional
changes (i.e. exactly what commit subject says)?