From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 33E9624D9F for ; Fri, 17 Aug 2018 09:46:54 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pvrliIBTP_0w for ; Fri, 17 Aug 2018 09:46:54 -0400 (EDT) Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 937E724D5D for ; Fri, 17 Aug 2018 09:46:53 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool From: Nikita Tatunov In-Reply-To: <76466086-2a5f-8f12-cbc3-4ddf26e30fd9@tarantool.org> Date: Fri, 17 Aug 2018 16:46:49 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <034AD9AA-570E-4810-BB22-F82756578B35@tarantool.org> References: <4607dc428909e96915e9f0984a7733a0890a3185.1534436836.git.n.tatunov@tarantool.org> <76466086-2a5f-8f12-cbc3-4ddf26e30fd9@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Alexander Turenko , avkhatskevich@tarantool.org, korablev@tarantool.org Hello! Please, consider my note. > On 17 Aug 2018, at 11:25, Alex Khatskevich = wrote: >=20 >=20 >=20 > On 16.08.2018 20:00, N.Tatunov wrote: >> GLOB is a legacy extension for LIKE from SQLite. As we want our SQL = to >> be close to ANSI SQL & LIKE to depend on collations, we do not want = to >> support it. This patch totally removes it from Tarantool along with = any >> mentions of it. > 1.We delete it because it is not working properly, and instead of = fixing it we > want to replace it with more general regexp. Delete other unnecessary = thoughts > from this message. > 2. Do not use "we", "our" in commit messages. I can=E2=80=99t agree with the first note. I=E2=80=99m not sure if we = can call it a =E2=80=9Creplacement=E2=80=9D. Firstly we have long been having a ticket for REGEXP implementation and this fact is not concerned with GLOB removal somehow. Secondly the idea of removing GLOB appeared in light of collations in LIKE & in light of = absence of GLOB in most of other DBMSs.=