From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A37FF2BE07 for ; Mon, 26 Mar 2018 13:41:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 04pb6gTfja2O for ; Mon, 26 Mar 2018 13:41:24 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 642512BC1F for ; Mon, 26 Mar 2018 13:41:24 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 1/1] netbox: show is_nullable and collation fields References: <82848BBB-2A50-4CAC-852E-E5EE5C8247A3@tarantool.org> From: Kirill Shcherbatov Message-ID: <02f53c50-c3eb-9e8c-6d15-9adfb7d23c0d@tarantool.org> Date: Mon, 26 Mar 2018 20:41:21 +0300 MIME-Version: 1.0 In-Reply-To: <82848BBB-2A50-4CAC-852E-E5EE5C8247A3@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "v.shpilevoy@tarantool.org" Cc: tarantool-patches@freelists.org diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua index fe45721..3b4ce05 100644 --- a/test/box/net.box.test.lua +++ b/test/box/net.box.test.lua @@ -799,11 +799,9 @@ box.schema.user.revoke('guest','read,write,execute','universe')  space:drop() -  --  -- gh-3256 net.box is_nullable and collation options output  -- -  space = box.schema.create_space('test')  box.schema.user.grant('guest','read,write,execute','space', 'test')  pk = space:create_index('pk') @@ -821,4 +819,5 @@ c = net:connect(box.cfg.listen)  c.space.test.index.sk.parts  c:close()  box.internal.collation.drop('test') -space:drop() \ No newline at end of file +space:drop() + On 26.03.2018 20:24, v.shpilevoy@tarantool.org wrote: > See below 2 minor comments. > >> 26 марта 2018 г., в 20:20, Kirill Shcherbatov написал(а): >> >> Fixes #3256 >> --- >> >> Issue: https://github.com/tarantool/tarantool/issues/3256 >> Branch: https://github.com/tarantool/tarantool/compare/gh-3256-net-box-nullable-collation-options-output >> >> src/box/lua/net_box.lua | 6 ++++- >> test/box/net.box.result | 65 +++++++++++++++++++++++++++++++++++++++++++++++ >> test/box/net.box.test.lua | 24 +++++++++++++++++ >> 3 files changed, 94 insertions(+), 1 deletion(-) >> >> diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua >> index c7541ed..fe45721 100644 >> --- a/test/box/net.box.test.lua >> +++ b/test/box/net.box.test.lua >> @@ -798,3 +798,27 @@ c.space.test.index.test_index ~= nil >> box.schema.user.revoke('guest','read,write,execute','universe') >> >> space:drop() >> + >> + > 1. Please, do not put multiple empty lines, when it is not necessary. > >> +-- >> +-- gh-3256 net.box is_nullable and collation options output >> +-- >> + >> +space = box.schema.create_space('test') >> +box.schema.user.grant('guest','read,write,execute','space', 'test') >> +pk = space:create_index('pk') >> +sk = space:create_index('sk', {parts = {{2, 'unsigned', is_nullable = true}}}) >> +c = net:connect(box.cfg.listen) >> +c.space.test.index.sk.parts >> +c:close() >> +space:drop() >> + >> +space = box.schema.create_space('test') >> +box.schema.user.grant('guest','read,write,execute','space', 'test') >> +box.internal.collation.create('test', 'ICU', 'ru-RU') >> +sk = space:create_index('sk', { type = 'tree', parts = {{1, 'str', collation = 'test'}}, unique = true }) >> +c = net:connect(box.cfg.listen) >> +c.space.test.index.sk.parts >> +c:close() >> +box.internal.collation.drop('test') >> +space:drop() >> \ No newline at end of file > 2. Please, add an empty line at the end of the file. > >> -- >> 2.7.4 >> >