From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 245A741C5DA
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 11 Jun 2020 02:51:02 +0300 (MSK)
References: <cover.1591701695.git.sergepetrenko@tarantool.org>
 <3992b9bc805ebc1d83ff59d5c1050b89a6a66344.1591701695.git.sergepetrenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <02a64ca9-70c3-2dc9-7105-d30e5af211e4@tarantool.org>
Date: Thu, 11 Jun 2020 01:51:00 +0200
MIME-Version: 1.0
In-Reply-To: <3992b9bc805ebc1d83ff59d5c1050b89a6a66344.1591701695.git.sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/8] replication: introduce
 space.is_sync option
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, sergos@tarantool.org, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org

Thanks for sending the patch!

I added 'is_sync' flag to netbox schema. So as
netbox.space.<name>.is_sync is the same as
box.space.<name>.is_sync.

Also I added a check that is_local and is_sync
can't be specified together for one space. It
makes no sense.

I force pushed it on the branch gh-4842-sync-replication.
As well as all the other things I did in this email
thread.