From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7F2A5469710 for ; Wed, 27 May 2020 15:58:04 +0300 (MSK) From: Oleg Babin References: <20200527111406.145422-1-gorcunov@gmail.com> Message-ID: <02822615-4b8e-e90e-b990-27dee3237a32@tarantool.org> Date: Wed, 27 May 2020 15:58:03 +0300 MIME-Version: 1.0 In-Reply-To: <20200527111406.145422-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v3 00/10] lua/log: add an ability to setup logger without box.cfg{} List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Hi! Thanks for your changes. I think that it's a bit redundant to have "log" prefixes for log.cfg options. log.cfg({format = ..., level = ..., non_block = ...}) looks better IMO. Also it's still possible to setup invalid value for log_level. ``` tarantool> log.cfg{log_format = 'invalid'} --- - error: 'builtin/log.lua:239: log: ''log_format'' must be json,plain' ... tarantool> log.cfg{log_level = -1} --- ... tarantool> log.cfg --- - log_format: json log_level: -1 log_nonblock: false ... ``` Also I have several comments for specific commits. I'll send them separately. On 27/05/2020 14:13, Cyrill Gorcunov wrote: > In the series we add an ability to configure logger early > without calling box.cfg{}. The syntax is the same as > in box.cfg{} call. > > There was an idea to implement something similar via triggers but > I think this will require a way more efforts and code redesign, > so at first lets stick to simplier solution. > > v2 by Oleg: > - hide box_api symbols from users > - initialize logger via log.cfg() call to look similar to box.cfg > v3 by Oleg: > - add parametesr verification > - allow to reconfig via log.cfg() call > > branch gorcunov/gh-689-logger-3 > issue https://github.com/tarantool/tarantool/issues/689 > > Cyrill Gorcunov (10): > core/say: drop redundant declarations > core/say: drop vsay declaration > core/say: do not reconfig early set up logger > lua/log: declare say_logger_init and say_logger_initialized > lua/log: put string constants to map > lua/log: do not allow to set json for boot logger > lua/log: declare log as separate variable > lua/log: use log module settings inside box.cfg > lua/log: allow to configure logging without a box > test: use direct log module > > src/box/lua/load_cfg.lua | 24 +++- > src/lib/core/say.c | 18 ++- > src/lib/core/say.h | 8 +- > src/lua/log.lua | 216 +++++++++++++++++++++++++++++++---- > test/app-tap/logger.test.lua | 28 ++++- > 5 files changed, 255 insertions(+), 39 deletions(-) >