From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DD3A124E18 for ; Mon, 29 Jul 2019 17:01:34 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 82nZwKm3A4VJ for ; Mon, 29 Jul 2019 17:01:34 -0400 (EDT) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9CD2E24DFE for ; Mon, 29 Jul 2019 17:01:34 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 3/5] sql: use 'varbinary' as a name of type instead of 'blob' References: <2e655514-0fec-8baf-20a8-d49e5586b047@tarantool.org> From: Vladislav Shpilevoy Message-ID: <027525d2-deed-d70b-b06b-3e49bf92d7c3@tarantool.org> Date: Mon, 29 Jul 2019 23:03:39 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" , tarantool-patches@freelists.org Hi! Thanks for the fixes! On 29/07/2019 01:56, n.pettik wrote: > > >> On 26 Jul 2019, at 01:03, Vladislav Shpilevoy wrote: >> >> On 24/07/2019 13:42, Nikita Pettik wrote: >>> We are going to introduce new column type 'VARBINARY', which allows to >>> store values with MP_BIN msgpack format. On the other hand, now it is also >>> possible to meet this type: all literals in form of x'...' are >>> supposed to be inserted into SCALAR column type exactly with MP_BIN >>> encoding. Prior to this moment type of such values (encoded as MP_BIN) >>> was called 'blob'. Thus, let's fix all visible to user messages using >>> 'varbinary' name of type instead of 'blob'. >>> --- >>> src/box/lua/lua_sql.c | 2 +- >>> src/box/sql/func.c | 4 ++-- >>> src/box/sql/vdbe.c | 4 ++-- >>> src/box/sql/vdbeapi.c | 4 ++-- >>> test/sql-tap/cast.test.lua | 4 ++-- >>> test/sql-tap/func.test.lua | 2 +- >>> test/sql-tap/lua_sql.test.lua | 4 ++-- >>> test/sql-tap/position.test.lua | 16 ++++++++-------- >>> test/sql/types.result | 24 ++++++++++++------------ >>> 9 files changed, 32 insertions(+), 32 deletions(-) >> >> More mentionings of blob in messages visible to user. >> >> func.c :540, :1185, :1254, :1753 >> vdbeapi.c:283, :382, :1061 >> vdbemem.c:996, :1022 >> vdbeaux.c:1192 > > All these usages are in form of: > "string or blob is too big” > > I think that blob is a good name for entity of varbinary > type. Another possible names are “binary sequence”, > “binary data” or “binary string”. The latter variant is used > in the ANSI specification. Now I’ve changed to “binary string”, > but if you can suggest better name, let’s discuss it. No, I don't mind any name. I saw, that in the commit message you said "Thus, let's fix all visible to user messages using 'varbinary' name of type instead of 'blob'." And I noticed, that there are still visible messages mentioning blob. You can keep blob, or rename, or anything.