From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 661E3289F0 for ; Thu, 31 May 2018 11:55:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g4SxcmcBzT7U for ; Thu, 31 May 2018 11:55:43 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 26D3128968 for ; Thu, 31 May 2018 11:55:43 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 0/2] sql: Create special region for parser References: From: Vladislav Shpilevoy Message-ID: <02431d4f-c7a2-9881-c3fd-7f2d5b041c51@tarantool.org> Date: Thu, 31 May 2018 18:55:40 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov LGTM. On 31/05/2018 18:50, Kirill Shcherbatov wrote: > Moved sql_parser_create and sql_parser_destroy to sql.h to > use them not only in DDL. > Removed SELECTTRACE_ENABLED macro with conditional fields from > struct Parse to prevent different object sizes across the project. > Start use own region for parser to avoid unexpected memory releases. > > On 31.05.2018 18:01, Kirill Shcherbatov wrote: >> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3438-parser-own-region >> Issue: https://github.com/tarantool/tarantool/issues/3438 >> >> Kirill Shcherbatov (2): >> sql: remove parser construct, destruct to sql.h >> sql: use own region in Parser >> >> src/box/sql.h | 17 +++++++++++++++++ >> src/box/sql/build.c | 6 +++--- >> src/box/sql/prepare.c | 11 +++++++++-- >> src/box/sql/select.c | 2 +- >> src/box/sql/sqliteInt.h | 29 ++--------------------------- >> src/box/sql/tokenize.c | 10 ++++++---- >> 6 files changed, 38 insertions(+), 37 deletions(-) >> >