From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DCC222F449 for ; Fri, 17 May 2019 04:22:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mxswUNWKORpQ for ; Fri, 17 May 2019 04:22:43 -0400 (EDT) Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 487A92F447 for ; Fri, 17 May 2019 04:22:43 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 3/3] box: local sql_flags for parser and vdbe References: <5d4de78a-0ffe-5238-c2c9-8854a15b842f@tarantool.org> From: Kirill Shcherbatov Message-ID: <02355feb-9512-3f22-9d33-633963d14dc0@tarantool.org> Date: Fri, 17 May 2019 11:22:40 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, "n.pettik" Hi! Thank you for review. box: local sql_flags for parser and vdbe The sql_flags is a parser parameter that describes how to parse the SQL request, determines general behaviour: like whether foreign keys are handled as deferred or not etc. But now this information is taken from the global user session object. When we need to run the parser with some other parameters, it is necessary to change global session object, which may lead to unpredictable consequences in general case. Introduced a new parser and vdbe field sql_flags which is responsible for SQL parsing results. Needed for #3691 > Why not pass only flags from parsing context? Done. > Strictly speaking, they flags are not flags. 'options > The rest is OK.