From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DAB37469719 for ; Wed, 18 Mar 2020 10:12:07 +0300 (MSK) From: "Timur Safin" References: <005501d5fbb3$7c2895d0$7479c170$@tarantool.org> <8b260724-43f4-ea28-44f8-2ed423ea410e@tarantool.org> <05d301d5fc6a$125aa140$370fe3c0$@tarantool.org> <66b262dc-4ca1-2e45-3eed-577662d68b35@tarantool.org> In-Reply-To: <66b262dc-4ca1-2e45-3eed-577662d68b35@tarantool.org> Date: Wed, 18 Mar 2020 10:12:04 +0300 Message-ID: <022d01d5fcf4$884af050$98e0d0f0$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH v1.1] evio: workaround for wsl1 so_linger assertion List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Vladislav Shpilevoy' , 'Cyrill Gorcunov' Cc: tarantool-patches@dev.tarantool.org : -----Original Message----- : From: Vladislav Shpilevoy : Subject: Re: [PATCH v1.1] evio: workaround for wsl1 so_linger assertion : : > Yup, sorry for the omission, I should automate this somehow : > (because at the moment there are too many manual steps which are : > easy to forget or to skip. Do you have any advices/scripts here?) : : Yeah, I use this: : https://gist.github.com/Gerold103/5471a7ddbeec346c0c845930d5bb9df4 : But it is for bash. Don't know whether you use bash on Windows. That's quite nice. I'll try to automate it even further (i.e. there is no much need to provide manual branch information, and the number of patches to pick - all them could be automatically calculated), but it's very good start. : > : : > : > + : > : > elseif (${CMAKE_SYSTEM_NAME} STREQUAL "kFreeBSD") : > : > set(TARGET_OS_FREEBSD 1) : > : > set(TARGET_OS_DEBIAN_FREEBSD 1) : > : > @@ -19,6 +28,7 @@ elseif (${CMAKE_SYSTEM_NAME} STREQUAL "kFreeBSD") : > : > add_definitions("-D_FILE_OFFSET_BITS=64") : > : > find_package_message(PLATFORM "Building for Debian/kFreeBSD" : > : > "${CMAKE_SYSTEM_NAME}") : > : > + : > : : > : Please, omit not necessary diff. This and other new empty lines : > : below. : > : : > : > Ok, will remove these unnecessary lines added (though they did : > add some extra readability to the cmake scripts we have here :) ) : : Perhaps, but readability is a subjective thing usually. However : more important is that such unnecessary diff tends to pollute git : blame, and pad out patch size making it harder to review. Ok, ok, will get rid of them in next iteration. Regards, Timur