From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 05B962502B for ; Mon, 4 Feb 2019 14:11:56 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HgPCe3YZj166 for ; Mon, 4 Feb 2019 14:11:55 -0500 (EST) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6105C22B35 for ; Mon, 4 Feb 2019 14:11:55 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH] sql: remove tests on ORDER BY/LIMIT + DELETE References: <20190204153458.12559-1-ivan.koptelov@tarantool.org> From: Ivan Koptelov Message-ID: <02101d10-cf70-d974-ee0b-0f66166c73ca@tarantool.org> Date: Mon, 4 Feb 2019 22:11:51 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/html; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" , tarantool-patches@freelists.org 
On 4 Feb 2019, at 18:34, Ivan Koptelov <ivan.koptelov@tarantool.org> wrote:

Removes obsolete tests on ORDER BY/LIMIT + DELETE. This
functionality was not supported for some time, but a few tests
were still existing.

Closes #2172
---
Branch https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-by-and-limit-from-delete
Issue https://github.com/tarantool/tarantool/issues/2172

test/sql-tap/e_delete.test.lua | 188 -----------------------------------------
1 file changed, 188 deletions(-)

diff --git a/test/sql-tap/e_delete.test.lua b/test/sql-tap/e_delete.test.lua
index 84a4e0a22..0a81eb3bd 100755
--- a/test/sql-tap/e_delete.test.lua
+++ b/test/sql-tap/e_delete.test.lua
@@ -305,194 +305,6 @@ if (0 > 0) then
         DELETE FROM t8 NOT INDEXED WHERE a=5;
       END;]], {"NOT INDEXED"}},
    })
-    -- EVIDENCE-OF: R-64942-06615 The LIMIT and ORDER BY clauses (described
-    -- below) are unsupported for DELETE statements within triggers.
-    —

If I’m not mistaken, tests starting from e_delete-2.0 are disabled
(under if 0 > 0). So you can delete even more tests.
I thought we could enable this tests later?

Also, check SQLITE_ENABLE_UPDATE_DELETE_LIMIT define:
I guess it is related to this patch. Seems that it is turned off, so I
assume we can delete it alongside with code under it.
Yes, it turned off currently, but it may be turned on. This option also enables
UPDATE + LIMIT/ORDER BY statements and all code under 'define' appplies
to this functionality as well, so firstly I decided not to delete it.