From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 62986230F1 for ; Wed, 24 Jul 2019 12:54:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bS9pRcSlpBBR for ; Wed, 24 Jul 2019 12:54:05 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A42F222FB8 for ; Wed, 24 Jul 2019 12:54:04 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH 5/6] sql: introduce extended range for INTEGER type From: "n.pettik" In-Reply-To: <20190724155923.GA1031@atlas> Date: Wed, 24 Jul 2019 19:54:01 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <01A073A1-0F44-4A8C-A282-509BC0C74CA3@tarantool.org> References: <20190724155923.GA1031@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Konstantin Osipov > On 24 Jul 2019, at 18:59, Konstantin Osipov = wrote: >=20 > * Nikita Pettik [19/06/07 23:30]: >> @@ -72,11 +72,11 @@ execute('SELECT ?, ?, ?', {1, 2, 3}) >> --- >> - metadata: >> - name: '?' >> - type: INTEGER >> + type: UNSIGNED >> - name: '?' >> - type: INTEGER >> + type: UNSIGNED >> - name: '?' >> - type: INTEGER >> + type: UNSIGNED >> rows: >> - [1, 2, 3] >=20 > Nikita, >=20 > I know this decision came after you coded most of the patch, but > we agreed that unsigned integer literals should still have > "INTEGER" type, not "UNSIGNED", since INTEGER in tarantool fully > covers UNSIGNED range. Yep, I remember that and fixed that for literals: tarantool> select 1 --- - metadata: - name: '1' type: integer rows: - [1] =E2=80=A6 But failed (simply forgot) to fix that for binding values. So, juts want to clarify: we never set =E2=80=9CUNSIGNED=E2=80=9D type = for literals, even if they are in range [2^63, 2^64-1], right? If so, patch turns out to be pretty simple. > This leads to fewer surprises to users, e.g. when calculating > expression types. Could you please fix this? >=20 > --=20 > Konstantin Osipov, Moscow, Russia >=20