From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 003D7469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 18:38:00 +0300 (MSK)
References: <20200608104450.157253-1-gorcunov@gmail.com>
 <20200608104450.157253-2-gorcunov@gmail.com>
 <e731a0e8-1268-c1d4-6093-c32169e7ca5e@tarantool.org>
 <20200608153308.GK134822@grain>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <0195efc7-f32b-577b-69b7-92bbc5dcde69@tarantool.org>
Date: Mon, 8 Jun 2020 18:37:59 +0300
MIME-Version: 1.0
In-Reply-To: <20200608153308.GK134822@grain>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On 08/06/2020 18:33, Cyrill Gorcunov wrote:
> On Mon, Jun 08, 2020 at 06:29:25PM +0300, Oleg Babin wrote:
>> Hi! Thanks for your patch. See 1 comment below.
> ...
>>
>> I assume that "box_set_log_level" and "box_set_log_format" should be removed
>> as well.
> 
> Nope, they are called when we modify dynamic settings via box.cfg{}.
> 

Thanks for explanation. LGTM.