From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AAE1F6EC58; Wed, 4 Aug 2021 13:12:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AAE1F6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628071974; bh=zvqvUqzOVgMrDjcXDSi4NRtE7Pz1/4aARiG8ffmOZig=; h=To:Cc:References:In-Reply-To:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xYY37viiJXvgq+djifpXZMOcPjsHCEawJOs3YTCr37jKyiln8SMcmlt8M6u5b/IAF E8is5ptpJi9rv2E25pogFxbhR0W5l6Y7sv+IyurF3QyveBD0SxPYyfQHbI6P2svPGS dj4ZlAqV/GQQ3wYaYdkC+zsACQ83uHj4e9Fft4es= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 581B86EC58 for ; Wed, 4 Aug 2021 13:12:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 581B86EC58 Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1mBDtM-0004Bc-Ai; Wed, 04 Aug 2021 13:12:52 +0300 To: "'Serge Petrenko'" , , Cc: References: <726aea88a704e2eb11257d5de49fd03818a573ed.1627864075.git.tsafin@tarantool.org> <588cd867-94bf-f470-c99a-593ae589247b@tarantool.org> In-Reply-To: Date: Wed, 4 Aug 2021 13:12:52 +0300 Message-ID: <013901d78919$49a2c230$dce84690$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKU0cwvkTasfMq0ugtyZVj5je82UAMXJz2rAn8mP+8ByH0IPKmtjsCQ Content-Language: ru X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3FDAB68B812060C77E97CF8617D978122182A05F538085040AF6F1850D74CC88C396A5E17A67FAA9DE89B6C31CEE4ECBDB08F682DD90964C0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE758E3775C3D7FDEE4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CDA1F22AAA442F218638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D861D1E0ED40EB8B5AEC40115F5D26DA3C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC55B19328CBC4F849A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC65AC60A1F0286FE8FBB52F5C7ECD1BBD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3949686D59A6ADCEA6136E347CC761E07C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5567A841BA39CECBE8CF245E39E5E0C279D97736D1AF87C02D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473457D764E1CDE77A06594569410DEF1E3524DF9D4C91BFA9FB5C9ED579BA9E0E450EC1E4093ED751D7E09C32AA3244C954FCD6F05D195C7FC07F995D46FA87939C99C45E8D137E9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojeDyvyeZJDJH0mTZh0Go7TQ== X-Mailru-Sender: B5B6A6EBBD94DAD8D1BDE70A6C09405B65BA754297EB24BF8D7351001B2B8E43B579AF5D48B13B5D5C2808D6142752370A8ED71B308007E3DC85537438B7E1A423D748DE48713E689437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 6/9] box, datetime: datetime comparison for indices X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timur Safin via Tarantool-patches Reply-To: Timur Safin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello Sergey, Here is small update since previous message... > > You just need to assign the same HINT_VALUE_MAX hint to every > datetime value > > with date->secs >= HINT_VALUE_SECS_MAX. Otherwise the comparison > would > > make mistakes (judging by hint values only) for such far away > dates. > > Yes, thanks for the note, will make sure that values which exceed > selected > 36-bit will stick to the maximum value. Introduced this simple fix to the current code: ---------------------------------------- diff --git a/src/box/tuple_compare.cc b/src/box/tuple_compare.cc index f733b9f01..0c5e0b666 100644 --- a/src/box/tuple_compare.cc +++ b/src/box/tuple_compare.cc @@ -1659,7 +1659,8 @@ hint_datetime(struct datetime_t *date) int32_t nsec = date->nsec; uint64_t val = secs <= HINT_VALUE_SECS_MIN ? 0 : secs - HINT_VALUE_SECS_MIN; - val &= HINT_VALUE_SECS_MAX; + if (val >= HINT_VALUE_SECS_MAX) + val = HINT_VALUE_SECS_MAX; val <<= HINT_VALUE_NSEC_BITS; val |= (nsec >> HINT_VALUE_NSEC_SHIFT) & HINT_VALUE_NSEC_MAX; return hint_create(MP_CLASS_DATETIME, val); ---------------------------------------- Updated accordingly and force-pushed to the branch. > > But you don't allow datetime in SCALAR fields, as I see in the > previous > > commit. > > So you don't need to account for datetime in scalar hints. > > That's bug - every type is scalar type, unless it's collection (map > or array) > so datetime should be considered as scalar. That was oversight if > not. > Thanks! Also DATETIME is considered compatible with SCALAR type in MessagePack and with scalar column. Also updated patch, and force-pushed to branch. Thanks, Timur