From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsafin@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4C4D24765E0
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 22 Dec 2020 12:41:41 +0300 (MSK)
From: "Timur Safin" <tsafin@tarantool.org>
References: <97201353-fc4d-df72-e92c-261cc76107fc@tarantool.org>
In-Reply-To: <97201353-fc4d-df72-e92c-261cc76107fc@tarantool.org>
Date: Tue, 22 Dec 2020 12:41:34 +0300
Message-ID: <013401d6d846$a31040b0$e930c210$@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH] tpch: use normal perf image instead
	of patched one
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: 'Oleg Koshovetc' <okoshovetc@tarantool.org>, 'Alexander Tikhonov' <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

We need those patches to run whole TPC-H set (specifically Q13, Q17 and =
Q20, which are biggest outliers and which we have fixed with autoindex =
patches last quarter). We will return to proper datestamp support in SQL =
the next quarter Q1'21, unless then we had to live with patches.
=20
So, please don't.

Timur
: -----Original Message-----
: From: Oleg Koshovetc <okoshovetc@tarantool.org>
: Sent: Tuesday, December 22, 2020 2:21 AM
: To: Alexander Tikhonov <avtikhon@tarantool.org>; tsafin@tarantool.org
: Cc: tarantool-patches@dev.tarantool.org
: Subject: [PATCH] tpch: use normal perf image instead of patched one
:=20
: TPCH benchmark used to be launched with numerous patches applied
: to tarantool's source code. Not only it does not bench actual
: tarantool, it also adds extra complications in benchmarking process.
: Recently we got pipeline failed only because of tpch benchmark as it
: would fail to launch because it failed to apply all of the needed
: patches. Instead of fixing the patches we'd better get rid of that
: patching in the first place.
: ---
:   .gitlab-ci.yml | 2 +-
:   1 file changed, 1 insertion(+), 1 deletion(-)
:=20
: diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
: index 208ab24..935a27b 100644
: --- a/.gitlab-ci.yml
: +++ b/.gitlab-ci.yml
: @@ -328,7 +328,7 @@ perf_tpch:
:     <<: *perf_docker_test_definition
:     tags:
:       - docker_sh2_perf
: -  image: ${IMAGE_PERF_BUILT}_tpch
: +  image: ${IMAGE_PERF_BUILT}
:     variables:
:       <<: *perf_vars_definition
:       BENCH: 'tpch'
: --
: 2.7.4
:=20