From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DF802469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 14 Feb 2020 13:46:45 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
From: Serge Petrenko <sergepetrenko@tarantool.org>
In-Reply-To: <20200214072021.GB15237@atlas>
Date: Fri, 14 Feb 2020 13:46:45 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <0101E5CD-057D-4AD0-B815-0F09A454075B@tarantool.org>
References: <cover.1581630406.git.sergepetrenko@tarantool.org>
 <97f37279955ebc29e899164cc1364e6a0aea0f9b.1581630406.git.sergepetrenko@tarantool.org>
 <20200214072021.GB15237@atlas>
Subject: Re: [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to
 write a record with a broken lsn
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


> 14 =D1=84=D0=B5=D0=B2=D1=80. 2020 =D0=B3., =D0=B2 10:20, Konstantin =
Osipov <kostja.osipov@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB=
(=D0=B0):
>=20
> * sergepetrenko <sergepetrenko@tarantool.org> [20/02/14 09:46]:
>> From: Serge Petrenko <sergepetrenko@tarantool.org>
>>=20
>> There is an assertion in vclock_follow `lsn > prev_lsn`, which =
doesn't
>> fire in release builds, of course. Let's at least warn the user on an
>> attemt to write a record with a duplicate or otherwise broken lsn.
>=20
> wart is =D0=B1=D0=BE=D1=80=D0=BE=D0=B4=D0=B0=D0=B2=D0=BA=D0=B0.
>=20
> I think you meant warn :)
>=20
> otherwise lgtm
>=20
>=20
> --=20
> Konstantin Osipov, Moscow, Russia
> https://scylladb.com


Thanks!
--
Serge Petrenko
sergepetrenko@tarantool.org