From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 296D246970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  6 Feb 2020 01:22:58 +0300 (MSK)
References: <20200127140420.52553-1-k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <00aac4ac-e194-7c45-6cfd-7f288799d262@tarantool.org>
Date: Wed, 5 Feb 2020 23:22:56 +0100
MIME-Version: 1.0
In-Reply-To: <20200127140420.52553-1-k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] sql: fix segfault in pragma
 table_info
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch! LGTM.

On 27/01/2020 15:04, Chris Sosnin wrote:
> We should first check that primary key is not NULL.
> 
> Closes #4745
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4745-table-info-assertion
> issue: https://github.com/tarantool/tarantool/issues/4745