From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D6190264C7 for ; Sat, 9 Jun 2018 13:58:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HVkIUGC7tHFb for ; Sat, 9 Jun 2018 13:58:32 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8A3EC2649F for ; Sat, 9 Jun 2018 13:58:32 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 0/2] Box.session.sync From: Vladislav Shpilevoy References: Message-ID: <0084c17c-0529-a7d1-1813-0a066b195711@tarantool.org> Date: Sat, 9 Jun 2018 20:58:28 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: kostja@tarantool.org Sorry. Forgot the description. The patchset fixes box.session.sync(). Before the patchset box.session.sync() is session global, and is changed after a new request arrives. So box.session.sync() can be safely used only when a connection behind the session is not multiplexed. But box.session.push() can be used in a multiplexed connection and uses box.session.sync() as a default sync. So it needs box.session.sync() be request local. On 09/06/2018 20:49, Vladislav Shpilevoy wrote: > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3450-session-sync > Issue: https://github.com/tarantool/tarantool/issues/3450 > > Vladislav Shpilevoy (2): > fiber: remove fiber local storage > session: fix box.session.sync() > > src/box/iproto.cc | 11 ++++-- > src/box/session.cc | 4 +- > src/box/session.h | 31 ++++++--------- > src/box/txn.c | 2 +- > src/box/txn.h | 2 +- > src/fiber.c | 9 +---- > src/fiber.h | 89 ++++++++++++++++++------------------------- > src/fiber_channel.c | 31 +++++---------- > src/lua/fiber.c | 19 ++++----- > test/box-tap/session.test.lua | 29 +++++++++++++- > 10 files changed, 106 insertions(+), 121 deletions(-) >