From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E283C270B4 for ; Tue, 26 Mar 2019 17:48:44 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GLMN2GodTYg9 for ; Tue, 26 Mar 2019 17:48:44 -0400 (EDT) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9B05E26CA4 for ; Tue, 26 Mar 2019 17:48:43 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v9 3/7] sql: remove box.sql.debug() References: <20190322154607.GE6548@chai> <20190325193952.GB11766@tarantool.org> From: Vladislav Shpilevoy Message-ID: <0077b7b4-c12a-af6b-672b-271b12e8b327@tarantool.org> Date: Wed, 27 Mar 2019 00:48:39 +0300 MIME-Version: 1.0 In-Reply-To: <20190325193952.GB11766@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Mergen Imeev Cc: kostja@tarantool.org Thanks for the patch! See 3 comments below. > commit 1e21fc73be5df524d500723bd3e47066475ee6b9 > Author: Mergen Imeev > Date: Thu Jan 31 14:09:51 2019 +0300 > > sql: remove box.sql.debug() > > Due to removing of box.sql.execute() it makes sense to remove 1. 'removing' -> 'removal'. > box.sql.debug() and move SQL statistics to box.stat. 2. For a foreign reader it is unknown that box.sql.execute() removal == box.sql removal. Probably, it should be said explicitly, that we want to remove the whole box.sql. > > Part or #3505 > > diff --git a/test/sql-tap/between.test.lua b/test/sql-tap/between.test.lua > index d56de4e..1663e39 100755 > --- a/test/sql-tap/between.test.lua > +++ b/test/sql-tap/between.test.lua > @@ -51,10 +51,10 @@ test:do_test( > -- is done. Then it appends the names of the table and index used. > -- > local function queryplan(sql) > - local sql_sort_count = box.sql.debug().sql_sort_count > + local sqlite_sort_count = box.stat.sql().sql_sort_count 3. 'sqlite' -> 'sql' > local data = test:execsql(sql) > local x = "nosort" > - if box.sql.debug().sql_sort_count - sql_sort_count then > + if box.stat.sql().sql_sort_count - sqlite_sort_count then > x = "sort" > end > table.insert(data,x)