From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B9E1121A4D for ; Tue, 26 Jun 2018 08:22:30 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UgJCZcbrMRqt for ; Tue, 26 Jun 2018 08:22:30 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 780A221898 for ; Tue, 26 Jun 2018 08:22:30 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: enable multi-engine tests for SQL References: <9418cbf4-7ffa-3cfd-a544-bd49b5e52a2c@tarantool.org> From: Kirill Shcherbatov Message-ID: <006ee2bb-5abc-d612-3a4f-c709d7f3c27f@tarantool.org> Date: Tue, 26 Jun 2018 15:22:26 +0300 MIME-Version: 1.0 In-Reply-To: <9418cbf4-7ffa-3cfd-a544-bd49b5e52a2c@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > Did you test sql-tap/ suite? Why is not it in the > patch? It could be updated automatically using a > short script that adds the engine setting at the > beginning of a file. Ok, I've change constructor to start SQL-TAP test with all engines. This patch should be merged after than "Vinyl read iterator skips tuples #3477" > 1. Just increase vinyl_max_tuple_size to the same value. This > test should work both for vinyl and memtx. Ok. +-- 4 * 1024 * 1024 is higher than vinyl max tuple size +old_tuple_size = box.cfg.vinyl_max_tuple_size +box.cfg{vinyl_max_tuple_size = 5 * 1024 * 1024} +_ = space:replace{1, 1, string.rep('a', 4 * 1024 * 1024) } +box.cfg{vinyl_max_tuple_size = old_tuple_size} > 2. Vinyl rollbacks failed transactions, but it does not > rollback the whole transaction on a non-caught exception. Ok. +box.rollback()