From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 378C442EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  2 Jul 2020 13:29:44 +0300 (MSK)
References: <20200702095054.367131-1-gorcunov@gmail.com>
 <20200702095054.367131-3-gorcunov@gmail.com>
 <1ed0cd76-9a93-0235-a580-ec046d8a3a0b@tarantool.org>
 <20200702101816.GF2256@grain>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <0061d10a-2bb5-40c1-d4c3-402296206b3d@tarantool.org>
Date: Thu, 2 Jul 2020 13:29:42 +0300
MIME-Version: 1.0
In-Reply-To: <20200702101816.GF2256@grain>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH v3 2/3] lua/log: allow to use json
	formatter early
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>, yaroslav.dynnikov@gmail.com

Thanks! LGTM.

On 02/07/2020 13:18, Cyrill Gorcunov wrote:
> On Thu, Jul 02, 2020 at 01:05:38PM +0300, Oleg Babin wrote:
>> Hi! Thanks for your patch! LGTM! See one minor nitpick below. I hope you
>> could just force-pushed proposed change.
>>
>> On 02/07/2020 12:50, Cyrill Gorcunov wrote:
>>>    -- Set value to log from box.cfg{}.
>>> -local function box_api_cfg_set(key, value)
>>> +local function box_api_cfg_set(cfg, key, value)
>>>        local log_key = box2log_keys[key]
>>> +    local aux_data
>> Seems this variable is unused and could be dropped.
> Yeah, thanks! Already changed and force pushed.