From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B4C75469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  4 May 2020 17:26:17 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <cover.1588292014.git.v.shpilevoy@tarantool.org>
 <5dc5d2b0aaad4fcfc157c5a6e6bd13025ba85a25.1588292014.git.v.shpilevoy@tarantool.org>
 <6c622f6c-19d9-a64b-5ccb-8799561ef7cf@tarantool.org>
 <cc767163-bfed-4312-9e59-ec5bbab45526@tarantool.org>
Message-ID: <005e03cf-5ef4-88c8-3759-7007eae577f9@tarantool.org>
Date: Mon, 4 May 2020 17:26:16 +0300
MIME-Version: 1.0
In-Reply-To: <cc767163-bfed-4312-9e59-ec5bbab45526@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH vshard 1/7] test: print errors in a
	portable way
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for answers and explanation. LGTM.


On 02/05/2020 23:08, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 
>> On 01/05/2020 03:16, Vladislav Shpilevoy wrote:
>>>    +-- Portable representation of an error, not depending on Tarantool
>>> +-- version and on any additional fields it can add. Trace is also
>>> +-- trimmed in order for the tests not to depend on line numbers of
>>> +-- the source files, which may slip into a .result file.
>>> +local function portable_error(err)
>>> +    return {code = err.code, type = err.type, message = err.message}
>>> +end
>>