From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 64D4423EBE
	for <tarantool-patches@freelists.org>; Mon, 23 Jul 2018 09:31:49 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id BGbIYuHCa3Xt for <tarantool-patches@freelists.org>;
	Mon, 23 Jul 2018 09:31:49 -0400 (EDT)
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1F4E923E7D
	for <tarantool-patches@freelists.org>; Mon, 23 Jul 2018 09:31:49 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 2/4] Complete module reload
References: <cover.1532344375.git.avkhatskevich@tarantool.org>
 <6ebbf656cf54e40298ffa067551c291beefd1f8c.1532344376.git.avkhatskevich@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <0047207a-712a-1d14-31d3-decf63608719@tarantool.org>
Date: Mon, 23 Jul 2018 16:31:46 +0300
MIME-Version: 1.0
In-Reply-To: <6ebbf656cf54e40298ffa067551c291beefd1f8c.1532344376.git.avkhatskevich@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, AKhatskevich <avkhatskevich@tarantool.org>

Hi! Thanks for the patch!

> diff --git a/vshard/replicaset.lua b/vshard/replicaset.lua
> index 99f59aa..6c8d477 100644
> --- a/vshard/replicaset.lua
> +++ b/vshard/replicaset.lua
> @@ -21,6 +21,7 @@
>   --                                  requests to the replica>,
>   --             net_sequential_fail = <count of sequential failed
>   --                                    requests to the replica>,
> +--             is_outdated = nil/true,

https://github.com/tarantool/vshard/blob/kh/gh-112-reload-mt-2/vshard/replicaset.lua#L24

Looks like the version on the branch actually is outdated
instead of the replica object. Please, push the latest
version.

>   --          }
>   --      },
>   --      master = <master server from the array above>,
> @@ -34,6 +35,7 @@
>   --      etalon_bucket_count = <bucket count, that must be stored
>   --                             on this replicaset to reach the
>   --                             balance in a cluster>,
> +--      is_outdated = nil/true,
>   --  }
>   --
>   -- replicasets = {