From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsafin@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 544BC469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 19:04:54 +0300 (MSK)
From: "Timur Safin" <tsafin@tarantool.org>
References: <18ca01d5fba7$1c19a2d0$544ce870$@tarantool.org>
 <20200316153202.GB27301@uranus>
In-Reply-To: <20200316153202.GB27301@uranus>
Date: Mon, 16 Mar 2020 19:04:52 +0300
Message-ID: <000b01d5fbac$a14afad0$e3e0f070$@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH] evio: workaround for wsl1 so_linger
	assertion
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: 'Cyrill Gorcunov' <gorcunov@gmail.com>
Cc: 'Cyrill Gorcunov' <gorcunov@tarantool.org>, 'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org



: -----Original Message-----
: From: Cyrill Gorcunov <gorcunov@gmail.com>
: Sent: Monday, March 16, 2020 6:32 PM
: To: Timur Safin <tsafin@tarantool.org>
: Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>; Cyrill Gorcunov
: <gorcunov@tarantool.org>; tarantool-patches@dev.tarantool.org
: Subject: Re: [Tarantool-patches] [PATCH] evio: workaround for wsl1
: so_linger assertion
: 


: > +
: > +    # There are some subtle differences in Linux kernel calls
: > +    # implementation under WSL1 (which should go away with WSL2 kernel)
: > +    # so for a moment we introduce a way to distinguish Linux and
: > +    # Microsoft/WSL1
: > +    if (${CMAKE_SYSTEM} MATCHES "Linux-.*-Microsoft")
: > +        add_definitions("-DTARANTOOL_WSL_WORKAROUND_ENABLED=1")
: > +    endif()
: > +
: 
: Great! Thanks a huge, Timur! Since you mentioned WSL2 maybe we should
: name it -DTARANTOOL_WSL_1 ? I don't insist though.
: 
: Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>

Agreed, will rename it shortly to *WSL1_WORKAROUND*

Timur