Tarantool discussions archive
 help / color / mirror / Atom feed
From: Peter Gulutzan <pgulutzan@ocelot.ca>
To: Mergen Imeev <imeevma@tarantool.org>,
	tarantool-discussions@dev.tarantool.org, korablev@tarantool.org,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tsafin@tarantool.org
Subject: Re: [Tarantool-discussions] Implicit cast for assignment between numeric types and type mismatch error description.
Date: Tue, 23 Jun 2020 13:42:06 -0600	[thread overview]
Message-ID: <864ee43e-70d7-df03-02a8-882dcc4e6563@ocelot.ca> (raw)
In-Reply-To: <8770c30c-b8f4-b9f5-e472-be9a967dc251@tarantool.org>

Hi,

On 2020-06-23 10:15 a.m., Mergen Imeev wrote:
<cut>
 > Thanks for the answer. However, I now have another question:
 > should we apply these rules for cases like this:
 > SELECT * FROM t LIMIT 2.5;
 >
 > I mean, we should throw an error here or execute it like this:
 > SELECT * FROM t LIMIT 2;
<cut>

In the SQL-standard equivalent of LIMIT n,
which is FETCH FIRST n ROWS, that is a syntax
error because
"The declared type of <fetch first row count>
shall be an exact numeric with scale 0 (zero)."
For us it is a runtime error ...
"
tarantool> n = 0.000000001
---
...
tarantool> box.execute([[SELECT 5 LIMIT ?;]], {n})
---
- null
- 'Failed to execute SQL statement: Only positive
   integers are allowed in the LIMIT
   clause'
...
"
and you are proposing that there should be no error.
On the other hand,
box.execute([[CREATE TABLE t (s1 VARCHAR(2.0) PRIMARY KEY);]])
causes a "Syntax error", and you are not proposing
that we change that.
Another case is
box.execute([[SELECT SUBSTR('abcde',2.99);]])
which is legal, 2.99 is truncated to 2.

Therefore, I think your proposal means:
If n is not an integer,
and that is not detected as a syntax error,
then there should be no error or warning.
And I think the precedent of substr() means:
there should be truncation not rounding.

If I have understood correctly, then I agree.

Peter Gulutzan

  reply	other threads:[~2020-06-23 19:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 11:52 Mergen Imeev
2020-06-22 18:43 ` Peter Gulutzan
2020-06-23 16:15   ` Mergen Imeev
2020-06-23 19:42     ` Peter Gulutzan [this message]
2020-06-25  8:02       ` Mergen Imeev
2020-06-25 19:39         ` Peter Gulutzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864ee43e-70d7-df03-02a8-882dcc4e6563@ocelot.ca \
    --to=pgulutzan@ocelot.ca \
    --cc=imeevma@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-discussions@dev.tarantool.org \
    --cc=tsafin@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-discussions] Implicit cast for assignment between numeric types and type mismatch error description.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox