From: Igor Munkin <imun@tarantool.org> To: Konstantin Osipov <kostja.osipov@gmail.com> Cc: tarantool-discussions@dev.tarantool.org Subject: Re: [Tarantool-discussions] Addition of NUMBER field type Date: Fri, 20 Dec 2019 17:35:20 +0300 [thread overview] Message-ID: <20191220143520.GB31304@tarantool.org> (raw) In-Reply-To: <20191219141614.GB26708@atlas> On 19.12.19, Konstantin Osipov wrote: > * Mergen Imeev <imeevma@tarantool.org> [19/12/19 16:44]: > > Hi all, > > I would like to discuss once again the problem of adding a DOUBLE > > field type. > > > > Suppose we have added a DOUBLE field type to which we can insert > > data of type MP_DOUBLE in the format MsgPack. The problem is that > > inserting an integer from Lua, we get an error. This is not so bad > > for integer cdata, but it is bad for integers od Lua type NUMBER. > > Currently, we have 5 ways to solve the problem: > > <snipped> > > > > 4) Give to user a function to convert a number to DOUBLE in Lua > > before inserting into space. > > > > In this case, the user must convert the number to DOUBLE before > > inserting. We do not add any implicit cast. Very easy to > > understand and implement. Although the user may be a little > > confused that he cannot insert INTEGER/UNSIGNED into a DOUBLE > > field, but this can be solved by writing about this in the > > documentation. > > > > In addition, if we convert to LuaJIT DOUBLE cdata, then we can use > > these cdata as the operand of an arithmetic operation. However, > > arithmetic operations for this type do not work correctly. And it > > will not be fixed, most likely. It should also be written in the > > documentation, I think. > > <snipped> > > I like it #4 too - it's cheap & efficient. Despite the broken arithmetics and assuming no one need this type in Lua -- yes, this is a good one. > > -- > Konstantin Osipov, Moscow, Russia -- Best regards, IM
next prev parent reply other threads:[~2019-12-20 14:37 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-19 13:43 Mergen Imeev 2019-12-19 14:16 ` Konstantin Osipov 2019-12-20 14:35 ` Igor Munkin [this message] 2019-12-21 16:29 ` Mergen Imeev 2019-12-23 7:18 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191220143520.GB31304@tarantool.org \ --to=imun@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-discussions@dev.tarantool.org \ --subject='Re: [Tarantool-discussions] Addition of NUMBER field type' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox