From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsafin@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 647EF445320
 for <tarantool-discussions@dev.tarantool.org>;
 Wed, 29 Jul 2020 11:54:16 +0300 (MSK)
From: "Timur Safin" <tsafin@tarantool.org>
References: <20200727122429.GA49280@tarantool.org>
In-Reply-To: <20200727122429.GA49280@tarantool.org>
Date: Wed, 29 Jul 2020 11:54:12 +0300
Message-ID: <018701d66585$d4c081d0$7e418570$@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Tarantool-discussions] The result type and argument types of
	the built-in SQL functions.
List-Id: Tarantool development process
 <tarantool-discussions.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-discussions>, 
 <mailto:tarantool-discussions-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-discussions/>
List-Post: <mailto:tarantool-discussions@dev.tarantool.org>
List-Help: <mailto:tarantool-discussions-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-discussions>, 
 <mailto:tarantool-discussions-request@dev.tarantool.org?subject=subscribe>
To: 'Mergen Imeev' <imeevma@tarantool.org>, pgulutzan@ocelot.ca, korablev@tarantool.org, v.shpilevoy@tarantool.org, sergos@tarantool.org, tarantool-discussions@dev.tarantool.org


I general, I agree that UNSIGNED is unnecessary, but the rest of table
is pretty much ok with me. (Though blob vs string discussion opened elsewhere
is important)

With one small note below...

: From: Mergen Imeev <imeevma@tarantool.org>
: Subject: The result type and argument types of the built-in SQL functions.
: 
: Hi, Peter!
: 
: I would like to ask you a few questions about the result type and argument
: types of the SQL built-in functions.
: 
: I suggest changing the result types of some functions. A table with the
: current
: result type and the suggested result type is below.
: 
: FUNCTION NAME		CURRENT		SUGGESTED
: abs			number		number
: avg			number		double
: char			string		string
: character_length	integer		unsigned
...
: soundex			string		string
: substr			string		string
: sum			number		number
: total			number		double

Why total should be different than sum? (I'd use the same number)


Regards,
Timur