<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Thanks! LGTM</p>
<div class="moz-cite-prefix">On 8/28/26 13:45, Evgeniy Temirgaleev
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1787913937.662681336@f185.i.mail.ru">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div class="cl-4qn6f0wasx">
<div>Hi, Sergey! Thanks for review!</div>
<div>Fixed your suggestion. The branch is force pushed.</div>
<div class="mail-quote-collapse">
<blockquote
style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><span>From:
Sergey Bronnikov <<a
href="mailto:sergeyb@tarantool.org"
moz-do-not-send="true" class="moz-txt-link-freetext">sergeyb@tarantool.org</a>><br>
To: Evgeniy Temirgaleev <<a
href="mailto:e.temirgaleev@tarantool.org"
moz-do-not-send="true" class="moz-txt-link-freetext">e.temirgaleev@tarantool.org</a>>,
Sergey Kaplun <<a href="mailto:skaplun@tarantool.org"
moz-do-not-send="true" class="moz-txt-link-freetext">skaplun@tarantool.org</a>><br>
Cc:<a href="mailto:tarantool-patches@dev.tarantool.org"
moz-do-not-send="true" class="moz-txt-link-freetext">tarantool-patches@dev.tarantool.org</a><br>
Date: Thursday, August 27, 2026 12:35 PM +03:00</span><br>
<div>
<div id="">
<div class="cl-syz9qcuftz">
<div
class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr">
<div id="style_17878233081827893143_mr_css_attr">
<div
id="style_17878233081827893143_BODY_mr_css_attr">
<p>Hi, Evgeniy,</p>
<p>thanks for the patch! LGTM with minor
comments.</p>
<p>Sergey</p>
<div class="moz-cite-prefix_mr_css_attr">On
8/8/26 02:00, Evgeniy Temirgaleev wrote:</div>
<blockquote type="cite">
<pre class="moz-quote-pre_mr_css_attr">From: Temir Galeev <a
href="mailto:temir.galeev@bk.ru"
class="moz-txt-link-rfc2396E_mr_css_attr"
moz-do-not-send="true"><temir.galeev@bk.ru></a>
The brew gcc installation is useless, because cmake use
the clang compiler which is already present in the system.
Also, the clang is better than gcc for macOS.
Branch: <a
href="https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac"
class="moz-txt-link-freetext_mr_css_attr moz-txt-link-freetext"
moz-do-not-send="true">https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac</a>
---
.github/actions/setup-macos/action.yml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
index 91632648..9e752a70 100644
--- a/.github/actions/setup-macos/action.yml
+++ b/.github/actions/setup-macos/action.yml
@@ -32,6 +32,9 @@ runs:
# Try to install the packages either upgrade it to avoid
# of fails if the package already exists with the previous
# version.
- brew install --force cmake gcc make ninja perl ||
- brew upgrade cmake gcc make ninja perl
+ # We skip gcc installation because the 'builtin' clang compiler</pre>
</blockquote>
<p><span lang="en" class="HwtZe_mr_css_attr"><span
class="jCAhz_mr_css_attr"><span
class="ryNqvb_mr_css_attr">We usually
write comments in a depersonalized
manner and names in uppercase:</span></span></span></p>
<p><span lang="en" class="HwtZe_mr_css_attr"><span
class="jCAhz_mr_css_attr"><span
class="ryNqvb_mr_css_attr">> Skip GCC
installation because the 'builtin' clang
compiler<br>
> is already present in the system.
It is used by CMake<br>
> by default even if GCC is
installed.</span></span></span></p>
<blockquote type="cite">
<pre class="moz-quote-pre_mr_css_attr">+ # is already present in the system. It is used by cmake
+ # by default even if gcc is installed.
+ brew install --force cmake make ninja perl ||
+ brew upgrade cmake make ninja perl
shell: bash</pre>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
<div>
<div>
<div>diff --git a/.github/actions/setup-macos/action.yml
b/.github/actions/setup-macos/action.yml</div>
<div>index 9e752a70..28693c3f 100644</div>
<div>--- a/.github/actions/setup-macos/action.yml</div>
<div>+++ b/.github/actions/setup-macos/action.yml</div>
<div>@@ -32,9 +32,9 @@ runs:</div>
<div> # Try to install the packages either upgrade it
to avoid</div>
<div> # of fails if the package already exists with
the previous</div>
<div> # version.</div>
<div>- # We skip gcc installation because the 'builtin'
clang compiler</div>
<div>- # is already present in the system. It is used
by cmake</div>
<div>- # by default even if gcc is installed.</div>
<div>+ # Skip GCC installation because the 'builtin'
Clang compiler</div>
<div>+ # is already present in the system. It is used
by CMake</div>
<div>+ # by default even if GCC is installed.</div>
<div> brew install --force cmake make ninja perl ||</div>
<div> brew upgrade cmake make ninja perl</div>
<div> shell: bash</div>
</div>
</div>
<div>
<div>--<br>
Best regards,</div>
<div>Evgeniy Temirgaleev</div>
</div>
</blockquote>
</body>
</html>