<HTML><BODY><div class="cl-wpcniu5d93"><div>Hi, Sergey! Thanks for review!</div><div>Fixed your suggestion.</div><div>The branch is force pushed.</div><div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><span>From: Sergey Bronnikov <<a href="mailto:sergeyb@tarantool.org">sergeyb@tarantool.org</a>><br>To: Evgeniy Temirgaleev <<a href="mailto:e.temirgaleev@tarantool.org">e.temirgaleev@tarantool.org</a>>, Sergey Kaplun <<a href="mailto:skaplun@tarantool.org">skaplun@tarantool.org</a>><br>Cc:<a href="mailto:tarantool-patches@dev.tarantool.org">tarantool-patches@dev.tarantool.org</a><br>Date: Thursday, August 27, 2026 2:53 PM +03:00</span><br> <div><div id=""><div class="cl-3y40hco1kk"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div id="style_17878316240491502037_mr_css_attr"><div id="style_17878316240491502037_BODY_mr_css_attr">Hi, Evgeniy,<br><br>thanks for the patch! LGTM with a minor comment below.<br><br><br>Sergey<br><br>On 8/6/26 15:47, Evgeniy Temirgaleev wrote:<br>> From: Temir Galeev <<a href="mailto:temir.galeev@bk.ru">temir.galeev@bk.ru</a>><br>><br>> LuaJIT tests use fixup for Linux to run binaries made with<br>> the ASAN option. Our LibRealPath module is used for it.<br>> This module doesn't support OSX and breaks the make process.<br>><br>> So, we disable the fixup for OSX to allow LuaJIT making<br>> and running the tests with ASAN enabled.<br>> ---<br>> test/LuaJIT-tests/CMakeLists.txt | 3 ++-<br>> test/tarantool-tests/CMakeLists.txt | 3 ++-<br>> 2 files changed, 4 insertions(+), 2 deletions(-)<br>><br>> diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt<br>> index c1dbde35..42967cbc 100644<br>> --- a/test/LuaJIT-tests/CMakeLists.txt<br>> +++ b/test/LuaJIT-tests/CMakeLists.txt<br>> @@ -17,7 +17,8 @@ else()<br>> list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")<br>> endif()<br>><br>> -if(LUAJIT_USE_ASAN)<br>> +if(LUAJIT_USE_ASAN<br>> + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")<br><br>could you please put logical operators on the previous line? Like this:<br><br>if(LUAJIT_USE_ASAN AND NOT<br><br> CMAKE_SYSTEM_NAME STREQUAL "Darwin")<br><br>the same below<br><br>> # When running LuaJIT-tests under ASAN, the internal ASAN check<br>> # failed:<br>> # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356<br>> diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt<br>> index 682a883a..e9930e22 100644<br>> --- a/test/tarantool-tests/CMakeLists.txt<br>> +++ b/test/tarantool-tests/CMakeLists.txt<br>> @@ -183,7 +183,8 @@ endforeach()<br>> # required that the ASan library go first in the `LD_PRELOAD`<br>> # list. Set it manually. The test will append it to the executed<br>> # process.<br>> -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU")<br>> +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"<br>> + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")<br>> LibRealPath(LIB_ASAN libasan.so)<br>> AppendTestEnvVar(<br>> "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"</div></div></div></div></div></div></blockquote></div></div><div><div><div>diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt</div><div>index 42967cbc..f08762b3 100644</div><div>--- a/test/LuaJIT-tests/CMakeLists.txt</div><div>+++ b/test/LuaJIT-tests/CMakeLists.txt</div><div>@@ -17,8 +17,8 @@ else()</div><div> list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")</div><div> endif()</div><div> </div><div>-if(LUAJIT_USE_ASAN</div><div>- AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")</div><div>+if(LUAJIT_USE_ASAN AND NOT</div><div>+ CMAKE_SYSTEM_NAME STREQUAL "Darwin")</div><div> # When running LuaJIT-tests under ASAN, the internal ASAN check</div><div> # failed:</div><div> # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356</div><div>diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt</div><div>index e9930e22..fcd6d692 100644</div><div>--- a/test/tarantool-tests/CMakeLists.txt</div><div>+++ b/test/tarantool-tests/CMakeLists.txt</div><div>@@ -183,8 +183,8 @@ endforeach()</div><div> # required that the ASan library go first in the `LD_PRELOAD`</div><div> # list. Set it manually. The test will append it to the executed</div><div> # process.</div><div>-if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"</div><div>- AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")</div><div>+if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU" AND NOT</div><div>+ CMAKE_SYSTEM_NAME STREQUAL "Darwin")</div><div> LibRealPath(LIB_ASAN libasan.so)</div><div> AppendTestEnvVar(</div><div> "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"</div></div></div><div><div>--<br>Best regards,</div><div>Evgeniy Temirgaleev</div></div></BODY></HTML>