<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi, Evgeniy,</p>
<p>thanks for the patch! LGTM with minor comments.</p>
<p>Sergey</p>
<div class="moz-cite-prefix">On 8/8/26 02:00, Evgeniy Temirgaleev
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20260807230049.13128-1-e.temirgaleev@tarantool.org">
<pre wrap="" class="moz-quote-pre">From: Temir Galeev <a class="moz-txt-link-rfc2396E" href="mailto:temir.galeev@bk.ru"><temir.galeev@bk.ru></a>
The brew gcc installation is useless, because cmake use
the clang compiler which is already present in the system.
Also, the clang is better than gcc for macOS.
Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac">https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac</a>
---
.github/actions/setup-macos/action.yml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
index 91632648..9e752a70 100644
--- a/.github/actions/setup-macos/action.yml
+++ b/.github/actions/setup-macos/action.yml
@@ -32,6 +32,9 @@ runs:
# Try to install the packages either upgrade it to avoid
# of fails if the package already exists with the previous
# version.
- brew install --force cmake gcc make ninja perl ||
- brew upgrade cmake gcc make ninja perl
+ # We skip gcc installation because the 'builtin' clang compiler</pre>
</blockquote>
<p><span class="HwtZe" lang="en"><span class="jCAhz"><span
class="ryNqvb">We usually write comments in a depersonalized
manner and names in uppercase:</span></span></span></p>
<p><span class="HwtZe" lang="en"><span class="jCAhz"><span
class="ryNqvb">> Skip GCC installation because the
'builtin' clang compiler<br>
> is already present in the system. It is used by CMake<br>
> by default even if GCC is installed.</span></span></span></p>
<blockquote type="cite"
cite="mid:20260807230049.13128-1-e.temirgaleev@tarantool.org">
<pre wrap="" class="moz-quote-pre">
+ # is already present in the system. It is used by cmake
+ # by default even if gcc is installed.
+ brew install --force cmake make ninja perl ||
+ brew upgrade cmake make ninja perl
shell: bash
</pre>
</blockquote>
</body>
</html>