

<HTML><BODY><div class="cl-f37mufwcmu">Hi, Sergey! Thanks for review!<br> <div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><span>From: Sergey Kaplun <<a href="mailto:skaplun@tarantool.org">skaplun@tarantool.org</a>><br>To: Evgeniy Temirgaleev <<a href="mailto:e.temirgaleev@tarantool.org">e.temirgaleev@tarantool.org</a>><br>Cc: Sergey Bronnikov <<a href="mailto:sergeyb@tarantool.org">sergeyb@tarantool.org</a>>,<a href="mailto:tarantool-patches@dev.tarantool.org">tarantool-patches@dev.tarantool.org</a><br>Date: Tuesday, August 18, 2026 1:25 PM +03:00</span><br> <div><div id=""><div class="cl-002fvuez8e"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div id="style_17870487020986235165_mr_css_attr"><div id="style_17870487020986235165_BODY_mr_css_attr">Hi, Evgeniy!<br>Thanks for the patch and fixes.<br>LGTM, with the minor nit below.<br><br>On 06.08.26, Evgeniy Temirgaleev wrote:<br>> From: Temir Galeev <<a href="mailto:temir.galeev@bk.ru">temir.galeev@bk.ru</a>><br><br><snipped><br><br>> ---<br>> test/LuaJIT-tests/CMakeLists.txt | 3 ++-<br>> test/tarantool-tests/CMakeLists.txt | 3 ++-<br>> 2 files changed, 4 insertions(+), 2 deletions(-)<br>><br>> diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt<br>> index c1dbde35..42967cbc 100644<br>> --- a/test/LuaJIT-tests/CMakeLists.txt<br>> +++ b/test/LuaJIT-tests/CMakeLists.txt<br>> @@ -17,7 +17,8 @@ else()<br>> list(APPEND LUAJIT_TESTS_ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")<br>> endif()<br>><br>> -if(LUAJIT_USE_ASAN)<br>> +if(LUAJIT_USE_ASAN<br>> + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")<br><br>Minor: Looks like these lines may be joint.</div></div></div></div></div></div></blockquote></div></div><div>It was so. But when I added this guard to the second place, I decided to make the change same in both places.</div><div class="cl-f37mufwcmu"><div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><div><div><div class="cl-002fvuez8e"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div><br>> # When running LuaJIT-tests under ASAN, the internal ASAN check<br>> # failed:<br>> # AddressSanitizer: CHECK failed: asan_interceptors.cpp:356<br>> diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt<br>> index 682a883a..e9930e22 100644<br>> --- a/test/tarantool-tests/CMakeLists.txt<br>> +++ b/test/tarantool-tests/CMakeLists.txt<br>> @@ -183,7 +183,8 @@ endforeach()<br>> # required that the ASan library go first in the `LD_PRELOAD`<br>> # list. Set it manually. The test will append it to the executed<br>> # process.<br>> -if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU")<br>> +if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL "GNU"<br>> + AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")<br>> LibRealPath(LIB_ASAN libasan.so)<br>> AppendTestEnvVar(<br>> "test/${TEST_SUITE_NAME}/lj-522-fix-dlerror-return-null.test.lua"<br>> --<br>> 2.49.0<br>><br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></div></div></blockquote></div></div><div><div>Best regards,</div><div>Evgeniy Temirgaleev</div></div></BODY></HTML>