

<HTML><BODY><div class="cl-vvjey2fs1a">Hi, Sergey! Thanks for review!<br> <div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><span>From: Sergey Kaplun <<a href="mailto:skaplun@tarantool.org">skaplun@tarantool.org</a>><br>To: Evgeniy Temirgaleev <<a href="mailto:e.temirgaleev@tarantool.org">e.temirgaleev@tarantool.org</a>><br>Cc: Sergey Bronnikov <<a href="mailto:sergeyb@tarantool.org">sergeyb@tarantool.org</a>>,<a href="mailto:tarantool-patches@dev.tarantool.org">tarantool-patches@dev.tarantool.org</a><br>Date: Tuesday, August 18, 2026 1:47 PM +03:00</span><br> <div><div id=""><div class="cl-ewvv2dov27"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div id="style_17870500731029225159_mr_css_attr"><div id="style_17870500731029225159_BODY_mr_css_attr">Hi, Evgeniy!<br>Thanks for the patch and fixes!<br>Generally LGTM, but please clarify my questions below.<br><br>On 06.08.26, Evgeniy Temirgaleev wrote:<br>> From: Temir Galeev <<a href="mailto:temir.galeev@bk.ru">temir.galeev@bk.ru</a>><br>><br>> The arm64 and x86_64 architectures with clang/gcc compiler were added<br>> to the matrix.<br>> ---<br>> .../README.md | 0<br>> .../action.yml | 8 +-<br>> .../actions/setup-sanitizers-macos/README.md | 15 +++<br>> .../actions/setup-sanitizers-macos/action.yml | 73 +++++++++++++<br>> .github/workflows/sanitizers-testing.yml | 101 ++++++++++++++++--<br>> 5 files changed, 186 insertions(+), 11 deletions(-)<br>> rename .github/actions/{setup-sanitizers => setup-sanitizers-linux}/README.md (100%)<br>> rename .github/actions/{setup-sanitizers => setup-sanitizers-linux}/action.yml (76%)<br>> create mode 100644 .github/actions/setup-sanitizers-macos/README.md<br>> create mode 100644 .github/actions/setup-sanitizers-macos/action.yml<br>><br>> diff --git a/.github/actions/setup-sanitizers/README.md b/.github/actions/setup-sanitizers-linux/README.md<br>> similarity index 100%<br>> rename from .github/actions/setup-sanitizers/README.md<br>> rename to .github/actions/setup-sanitizers-linux/README.md<br>> diff --git a/.github/actions/setup-sanitizers/action.yml b/.github/actions/setup-sanitizers-linux/action.yml<br>> similarity index 76%<br>> rename from .github/actions/setup-sanitizers/action.yml<br>> rename to .github/actions/setup-sanitizers-linux/action.yml<br>> index 8642d553..18f5a75d 100644<br>> --- a/.github/actions/setup-sanitizers/action.yml<br>> +++ b/.github/actions/setup-sanitizers-linux/action.yml<br>> @@ -20,13 +20,17 @@ runs:<br>> - name: Install build and test dependencies<br>> run: |<br>> apt -y update<br>> + echo Available compilers:<br>> + export CC_FAMILY=`echo ${CC_NAME} | sed 's/-.*$//'`<br>> + apt list | grep -Pe "^${CC_FAMILY}-[0-9]+/"<br>> + # Try to install<br>> apt -y install ${CC_NAME} libstdc++-10-dev cmake ninja-build make perl<br>> shell: bash<br>> env:<br>> CC_NAME: ${{ inputs.cc_name }}<br>> - - name: Set specific C compiler as a default toolchain<br>> + - name: Set specific C compiler as a default toolchain for cmake<br>> run: |<br>> - echo CC=${CC_NAME} | tee -a $GITHUB_ENV<br>> + echo CMAKE_C_COMPILER=${CC_NAME} | tee -a $GITHUB_ENV<br>> shell: bash<br>> env:<br>> CC_NAME: ${{ inputs.cc_name }}<br><br>These changes look like debugging of the workflow. Are they necessary?</div></div></div></div></div></div></blockquote></div></div><div>I think it’s a useful information: Which compiler we can select just now with the current runner? For example, it used to answer your question below.</div><div>I added it advisedly, as it done for macOS action.</div><div class="cl-vvjey2fs1a"><div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><div><div><div class="cl-ewvv2dov27"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div><br>> diff --git a/.github/actions/setup-sanitizers-macos/README.md b/.github/actions/setup-sanitizers-macos/README.md<br>> new file mode 100644<br>> index 00000000..9ac5eb38<br>> --- /dev/null<br>> +++ b/.github/actions/setup-sanitizers-macos/README.md<br><br><snipped><br><br>> diff --git a/.github/actions/setup-sanitizers-macos/action.yml b/.github/actions/setup-sanitizers-macos/action.yml<br>> new file mode 100644<br>> index 00000000..9836ea03<br>> --- /dev/null<br>> +++ b/.github/actions/setup-sanitizers-macos/action.yml<br>> @@ -0,0 +1,73 @@<br><br><snipped><br><br>> + - name: Set CMAKE_BUILD_PARALLEL_LEVEL<br>> + shell: bash<br>> + run: |<br>> + # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to<br>> + # limit the number of parallel jobs for build/test step.<br>> + NPROC=$(sysctl -n hw.logicalcpu 2>/dev/null)<br>> + echo CMAKE_BUILD_PARALLEL_LEVEL=$(($NPROC + 1)) | tee -a $GITHUB_ENV<br>> + - name: Set MACOSX_DEPLOYMENT_TARGERT<br>> + shell: bash<br>> + run: |<br>> + # Set required MACOSX_DEPLOYMENT_TARGERT environment<br>> + # variable for Makefile.original build.<br>> + # See <a href="https://github.com/LuaJIT/LuaJIT/issues/484">https://github.com/LuaJIT/LuaJIT/issues/484</a>,<br>> + # <a href="https://github.com/LuaJIT/LuaJIT/issues/653">https://github.com/LuaJIT/LuaJIT/issues/653</a>.<br>> + echo MACOSX_DEPLOYMENT_TARGET=$(sw_vers -productVersion) | tee -a $GITHUB_ENV<br>> + - name: Install build and test dependencies<br>> + shell: bash<br>> + run: |<br>> + # Install brew using the command from Homebrew repository<br>> + # instructions: <a href="https://github.com/Homebrew/install">https://github.com/Homebrew/install</a>.<br>> + # XXX: 'echo' command below is required since brew<br>> + # installation script obliges the one to enter a newline<br>> + # for confirming the installation via Ruby script.<br>> + brew update ||<br>> + echo | /usr/bin/ruby -e "$(curl -fsSL <a href="https://raw.githubusercontent.com/Homebrew/install/master/install">https://raw.githubusercontent.com/Homebrew/install/master/install</a>)"<br>> + # Try to install the packages either upgrade it to avoid<br>> + # of fails if the package already exists with the previous<br>> + # version.<br>> + brew install --force ${CC_FORMULA} cmake make ninja perl ||<br>> + brew upgrade ${CC_FORMULA} cmake make ninja perl<br><br>Can we reuse setup-macos action instead these 3 steps?</div></div></div></div></div></div></blockquote></div></div><div>Yes, we can do it on top of the «ci: unused gcc removed from macOS setup» patch.</div><div>So, we need to merge it first. And then I shall update this patch.</div><div>Thanks for the notice.</div><div class="cl-vvjey2fs1a"><div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><div><div><div class="cl-ewvv2dov27"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div><br><snipped><br><br>> diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml<br>> index 4bf7d023..fe550b81 100644<br>> --- a/.github/workflows/sanitizers-testing.yml<br>> +++ b/.github/workflows/sanitizers-testing.yml<br><br><br><snipped><br><br>> + exclude:<br><br><snipped><br><br>> + - OS: Linux<br>> + CC: gcc-15<br>> + - OS: Linux<br>> + CC: clang-21<br><br>May we bump gcc and clang instead for Linux as well (I suppose its<br>about time :)) ?<br><br>I suppose it helps to avoid too many excludes. Also, there is no need<br>for testing these specific compilers instead of modern ones in<br>sanitizers build.<br><br>If there are any issues when upgrading compilers for sanitizer builds<br>(infrastructure or tests failures) -- feel free to ignore.<br><br><snipped></div></div></div></div></div></div></blockquote></div></div><div>I tried to use the top versions available for macOS and for Linux. We can’t use the same versions with our current setup.</div><div> </div><div>With the macOS runner we have:</div><div><span><span>Available formulas: ... gcc gcc@10 gcc@11 gcc@12 gcc@13 gcc@14 gcc@15 gcc@9 …</span></span></div><div><span><span>Available formulas: ... llvm llvm@14 llvm@15 llvm@16 llvm@17 llvm@18 llvm@19 llvm@20 llvm@21 ...</span></span></div><div> </div><div>With the Linux runner we have:</div><div> </div><div><div><div><div><div><span><span>gcc-10/focal-updates,now 10.5.0-1ubuntu1~20.04 amd64 [installed] </span></span></div></div><div><div><span><span>gcc-7/focal 7.5.0-6ubuntu2 amd64 </span></span></div></div><div><div><span><span>gcc-8/focal 8.4.0-3ubuntu2 amd64 </span></span></div></div><div><div><span><span>gcc-9/focal-updates,now 9.4.0-1ubuntu1~20.04.2 amd64 [installed,automatic] </span></span></div><div> </div></div><span><span>clang-10/focal,now 1:10.0.0-4ubuntu1 amd64 [installed,automatic] </span></span></div></div><div><div><span><span>clang-11/focal-updates,now 1:11.0.0-2~ubuntu20.04.1 amd64 [installed] </span></span></div></div><div><div><span><span>clang-12/focal-updates 1:12.0.0-3ubuntu1~20.04.5 amd64 </span></span></div></div><div><div><span><span>clang-18/focal-updates 1:18.1.8-11~20.04.2 amd64 </span></span></div></div><div><div><span><span>clang-7/focal 1:7.0.1-12 amd64 </span></span></div></div><div><div><span><span>clang-8/focal 1:8.0.1-9 amd64 </span></span></div></div><div><div><span><span>clang-9/focal 1:9.0.1-12 amd64 </span></span></div></div></div><div> </div><div>The clang18 have broken dependencies with the current version of setup-sanitizers-linux. So I leave the current version in the context of ‘fix sanitizers for macOS patch’.</div><div><div><div> </div></div></div><div class="cl-vvjey2fs1a"><div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><div><div><div class="cl-ewvv2dov27"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div><br><br>> --<br>> 2.49.0<br>><br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></div></div></blockquote></div></div><div><div><br>Best regards,</div><div>Evgeniy Temirgaleev</div></div></BODY></HTML>