<HTML><BODY><div class="cl-e07scjo3f3"><p>Hi, Sergey, thanks for the patch!</p><div> </div>The 2..6 commits are LGTM.<br> <div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Evgeniy Temirgaleev</div></div></div><br><div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><span>From: Sergey Kaplun <<a href="mailto:skaplun@tarantool.org">skaplun@tarantool.org</a>><br>To: Mikhail Elhimov <<a href="mailto:m.elhimov@vk.team">m.elhimov@vk.team</a>>, Sergey Bronnikov <<a href="mailto:sergeyb@tarantool.org">sergeyb@tarantool.org</a>>, Evgeniy Temirgaleev <<a href="mailto:e.temirgaleev@tarantool.org">e.temirgaleev@tarantool.org</a>><br>Cc: tarantool-patches@dev.tarantool.org, Sergey Kaplun <<a href="mailto:skaplun@tarantool.org">skaplun@tarantool.org</a>><br>Date: Tuesday, May 19, 2026 3:39 PM +03:00</span><br> <div><div id=""><div class="cl-be34lpckfs"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div id="style_17791943990228942924_mr_css_attr"><div id="style_17791943990228942924_BODY_mr_css_attr">This patchset adds tests for LLDB and GDB debugger extensions via the<br>first commit. The next two commits refactor the LLDB extension and sort<br>initialized commands alphabetically. The fourth commit adds the<br>lightuserdata support for LJ_64 for LLDB too. The next commit joins<br>extension logic into the single file, making the LuaJIT-related code<br>debugger-agnostic. The last commit adds the CI workflow for arm64 and<br>x86_64 architectures.<br><br>Branch: <a href="https://github.com/tarantool/luajit/tree/skaplun/unified-debugger">https://github.com/tarantool/luajit/tree/skaplun/unified-debugger</a><br><br>Changes in the v2:<br>Moved squashed part of the refactoring from the third commit to the<br>second one.<br><br>Maksim Kokryashkin (1):<br>test: introduce tests for debugging extensions<br><br>Sergey Kaplun (5):<br>lldb: refactor extension<br>dbg: sort initialization of commands<br>lldb: support full-range 64-bit lightuserdata<br>dbg: generalize extension<br>ci: introduce workflow to test debugger extension<br><br>.flake8rc | 5 -<br>.github/actions/setup-debuggers/README.md | 13 +<br>.github/actions/setup-debuggers/action.yml | 12 +<br>.github/workflows/debuggers.yml | 61 +<br>src/luajit-gdb.py | 884 ------------<br>src/luajit_dbg.py | 1281 +++++++++++++++++<br>src/luajit_lldb.py | 1124 ---------------<br>test/CMakeLists.txt | 7 +<br>test/tarantool-debugger-tests/CMakeLists.txt | 93 ++<br>.../debug-extension-tests.py | 292 ++++<br>10 files changed, 1759 insertions(+), 2013 deletions(-)<br>create mode 100644 .github/actions/setup-debuggers/README.md<br>create mode 100644 .github/actions/setup-debuggers/action.yml<br>create mode 100644 .github/workflows/debuggers.yml<br>delete mode 100644 src/luajit-gdb.py<br>create mode 100644 src/luajit_dbg.py<br>delete mode 100644 src/luajit_lldb.py<br>create mode 100644 test/tarantool-debugger-tests/CMakeLists.txt<br>create mode 100644 test/tarantool-debugger-tests/debug-extension-tests.py<br><br>--<br>2.53.0</div></div></div></div></div></div></blockquote></div></div></BODY></HTML>