<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<div class="moz-cite-prefix">LGTM with a comment below.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Sergey</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 5/25/26 12:14, Sergey Kaplun wrote:<br>
</div>
<p><snipped></p>
<blockquote type="cite" cite="mid:ahQS-SfodLS6C-Ns@root">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt
new file mode 100644
index 00000000..7fd0debc
--- /dev/null
+++ b/test/tarantool-debugger-tests/CMakeLists.txt
@@ -0,0 +1,93 @@
+set(TEST_SUITE_NAME "tarantool-debugger-tests")
+
+# XXX: The call produces both test and target
+# <tarantool-debugger-tests-deps> as a side effect.
+add_test_suite_target(tarantool-debugger-tests
+ LABELS ${TEST_SUITE_NAME}
+ DEPENDS ${LUAJIT_TEST_BINARY}
+)
+
+# Debug info is required for testing of extensions.
+if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
+ message(WARNING
+ "Not a DEBUG build, tarantool-debugger-tests is dummy"
+ )
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
it is not dummy, it doesn't exist at all:
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release
cd build
make tarantool-debugger-tests
make[3]: *** No rule to make target 'src/luajit', needed by
'test/tarantool-debugger-tests/CMakeFiles/tarantool-debugger-tests-deps'.
Stop.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Replaced elsewhere with "omitted<a class="moz-txt-link-rfc2396E" href="mailto:.===================================================================diff--gita/test/tarantool-debugger-tests/CMakeLists.txtb/test/tarantool-debugger-tests/CMakeLists.txtindex7fd0debc..a6684e72100644---a/test/tarantool-debugger-tests/CMakeLists.txt+++b/test/tarantool-debugger-tests/CMakeLists.txt@@-10,7+10,7@@add_test_suite_target(tarantool-debugger-tests#Debuginfoisrequiredfortestingofextensions.if(NOT(CMAKE_BUILD_TYPEMATCHESDebug))message(WARNING-">".
===================================================================
diff --git a/test/tarantool-debugger-tests/CMakeLists.txt b/test/tarantool-debugger-tests/CMakeLists.txt
index 7fd0debc..a6684e72 100644
--- a/test/tarantool-debugger-tests/CMakeLists.txt
+++ b/test/tarantool-debugger-tests/CMakeLists.txt
@@ -10,7 +10,7 @@ add_test_suite_target(tarantool-debugger-tests
# Debug info is required for testing of extensions.
if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
message(WARNING
- "</a>Not a DEBUG build, tarantool-debugger-tests is dummy"
+ "Not a DEBUG build, tarantool-debugger-tests is omitted"
)
return()
endif()
@@ -22,7 +22,7 @@ endif()
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND DEFINED ENV{CI})
message(WARNING
"Interactive debugging is unavailable for macOS CI builds,"
- " tarantool-debugger-tests is dummy"
+ " tarantool-debugger-tests is omitted"
)
return()
endif()
@@ -31,13 +31,17 @@ if(CMAKE_VERSION VERSION_LESS "3.12")
# <a class="moz-txt-link-freetext" href="TODO:Can">TODO:Can</a> remove this after upgrading to CMake >= 3.12.
find_package(PythonInterp)
if(NOT PYTHONINTERP_FOUND)
- message(WARNING "`python` is not found, tarantool-debugger-tests is dummy")
+ message(WARNING
+ "`python` is not found, tarantool-debugger-tests is omitted"
+ )
return()
endif()
else()
find_package(Python COMPONENTS Interpreter)
if(NOT PYTHON_FOUND)
- message(WARNING "`python` is not found, tarantool-debugger-tests is dummy")
+ message(WARNING
+ "`python` is not found, tarantool-debugger-tests is omitted"
+ )
return()
endif()
set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}")
===================================================================
</pre>
</blockquote>
<p>Let's create a target after checking requirements:</p>
<p>diff --git a/test/tarantool-debugger-tests/CMakeLists.txt
b/test/tarantool-debugger-tests/CMakeLists.txt<br>
index 39414db3..ab90b803 100644<br>
--- a/test/tarantool-debugger-tests/CMakeLists.txt<br>
+++ b/test/tarantool-debugger-tests/CMakeLists.txt<br>
@@ -1,12 +1,5 @@<br>
set(TEST_SUITE_NAME "tarantool-debugger-tests")<br>
<br>
-# XXX: The call produces both test and target<br>
-# <tarantool-debugger-tests-deps> as a side effect.<br>
-add_test_suite_target(tarantool-debugger-tests<br>
- LABELS ${TEST_SUITE_NAME}<br>
- DEPENDS ${LUAJIT_TEST_BINARY}<br>
-)<br>
-<br>
# Debug info is required for testing of extensions.<br>
if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))<br>
message(WARNING<br>
@@ -47,6 +40,13 @@ else()<br>
set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}")<br>
endif()<br>
<br>
+# XXX: The call produces both test and target<br>
+# <tarantool-debugger-tests-deps> as a side effect.<br>
+add_test_suite_target(tarantool-debugger-tests<br>
+ LABELS ${TEST_SUITE_NAME}<br>
+ DEPENDS ${LUAJIT_TEST_BINARY}<br>
+)<br>
+<br>
set(DEBUGGER_TEST_ENV<br>
"LUAJIT_TEST_BINARY=${LUAJIT_TEST_BINARY}"<br>
# Suppresses __pycache__ generation.</p>
<p><snipped></p>
<blockquote type="cite" cite="mid:ahQS-SfodLS6C-Ns@root">
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>