<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey!</p>
<p><span class="HwtZe" lang="en"><span class="jCAhz ChMk0b"><span
class="ryNqvb">A few things worry me: we still don't know
the root cause of the problem.</span></span></span></p>
<p><span class="HwtZe" lang="en"><span class="jCAhz ChMk0b"><span
class="ryNqvb">The proposed patch merely reduces the
frequency of module installations.</span></span></span></p>
<p><span class="HwtZe" lang="en"><span class="jCAhz ChMk0b"><span
class="ryNqvb">And if an installation is required, the
installation will still break.</span></span></span></p>
<p><span class="HwtZe" lang="en"><span class="jCAhz ChMk0b"><span
class="ryNqvb">See comments inline.</span></span></span></p>
<p>Sergey</p>
<div class="moz-cite-prefix">On 4/23/26 20:08, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20260423170806.9647-1-skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">We have encountered the flakiness of the network on our CI runners. It
happens only on lua-cjson installation and only in some particular job
run.
This patch helps to deal with it by installing this package only if it</pre>
</blockquote>
s/helps to deal with it/helps to reduce a number of installations/
<blockquote type="cite"
cite="mid:20260423170806.9647-1-skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
is not installed in the system. Also, it installs it only for Lua 5.1,
which is compatible with LuaJIT.
---
Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson">https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson</a>
.github/actions/setup-performance/action.yml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/.github/actions/setup-performance/action.yml b/.github/actions/setup-performance/action.yml
index 4e0e1929..3c2a8230 100644
--- a/.github/actions/setup-performance/action.yml
+++ b/.github/actions/setup-performance/action.yml
@@ -11,7 +11,9 @@ runs:
apt install -y curl luarocks util-linux
shell: bash
- name: Install Lua modules
- run: luarocks install lua-cjson
+ run: >
+ luarocks --lua-version=5.1 show lua-cjson ||
+ luarocks --lua-version=5.1 install lua-cjson</pre>
</blockquote>
Why do we need specifying Lua version now? Previously, it worked
without setting exact version.
<blockquote type="cite"
cite="mid:20260423170806.9647-1-skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
shell: bash
- name: Run script to setup Linux environment
run: sh ./perf/helpers/setup_env.sh
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>