<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for the fixes!</p>
<p>Sergey</p>
<div class="moz-cite-prefix">On 3/13/26 13:07, Sergey Kaplun wrote:<br>
</div>
<p><br>
</p>
<p><snipped></p>
<blockquote type="cite" cite="mid:abPh4iY67H2yJubb@root">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
+local function test_trace_recorded(test_payload)
+ jit.flush()
+ -- Reset hotcounters.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">nit: comment can be omitted
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
I prefer not to. There may be the question: why we don't declare this
parameters once? The reason is that the hotcounters may cause collisions
and lead to the false-positive tests failures. Should I make the comment
more verbose?</pre>
</blockquote>
<p>We reset hotcounters in tests about 470 times (grep -R -B 1
"hotloop=1" test | wc -l) and only</p>
<p>15 times we add a comment like "Reset hotcounters.". You add a
comment here but missed it in the patch</p>
<p>"MIPS64: Avoid unaligned load in lj_vm_exit_interp.". Why we
should leave comment here and</p>
<p>omit it the aforementioned patch? I'll not insist removing it,
just interesting, it is not an issue for blocking merge.</p>
<blockquote type="cite" cite="mid:abPh4iY67H2yJubb@root">
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
<snipped>
<blockquote type="cite" cite="mid:abPh4iY67H2yJubb@root">
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>