<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for the patch! LGTM with a minor comment below.</p>
<p>Sergey</p>
<div class="moz-cite-prefix">On 3/6/26 16:42, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c4baa23d8d571ee62801502ec2392b3bcf8aa94c.1772803880.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">From: Mike Pall <mike>
Contributed by XmiliaH.
(cherry picked from commit af9763a50da87ff8ba16e828cbd5664135e05a88)
The generated ADD/SUB IRs for the calculation of indexes in the string
for the aforementioned build-ins don't check the overflow. This may lead</pre>
</blockquote>
s/build-ins/built-ins/
<blockquote type="cite"
cite="mid:c4baa23d8d571ee62801502ec2392b3bcf8aa94c.1772803880.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
to the incorrect results, incorrect trace semantics, or invalid memory
access. Also, the negative values may pass the UGT guard check emitted
for the positive `end` position and lead to the incorrect results on the
trace.
This patch fixes this by using guarded ADDOV/SUBOV instead. The UGT IR
is replaced with GT.
Sergey Kaplun:
* added the description and the test for the problem
Part of tarantool/tarantool#12134
---</pre>
</blockquote>
<p><snipped></p>
</body>
<lt-container></lt-container>
</html>