<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for long-awaited review!</p>
<div class="moz-cite-prefix">On 2/11/26 10:17, Sergey Kaplun via
Tarantool-patches wrote:<br>
</div>
<blockquote type="cite" cite="mid:aYwtIPtWodu_YZyz@root">
<pre wrap="" class="moz-quote-pre">Hi, Sergey!
Thanks for the patch!
LGTM, with minor nits.
On 10.12.25, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">From: Mike Pall <mike>
Thanks to François Perrad and Stefan Pejic.
(cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)
The patch fixes `xpcall()` segfaults on MIPS64 commit. The similar
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Typo: s/commit/architecture/
</pre>
</blockquote>
<p>Fixed.</p>
<p><br>
</p>
<blockquote type="cite" cite="mid:aYwtIPtWodu_YZyz@root">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">patch for ARM64 has been backported previously, see the commit
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Minor: s/backported previously/backported (with the test) previously/</pre>
</blockquote>
<p>Fixed as well.</p>
<p>Updated commit message:</p>
<p>commit b5a84d2ba13df4d48c8ba46ee41a93f17dc00782 (HEAD)<br>
Author: Mike Pall <mike><br>
Date: Sat Nov 18 12:25:35 2017 +0100<br>
<br>
MIPS64: Fix xpcall() error case.<br>
<br>
Thanks to François Perrad and Stefan Pejic.<br>
<br>
(cherry picked from commit
ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)<br>
<br>
The patch fixes `xpcall()` segfaults on MIPS64 architecture.<br>
The similar patch for ARM64 has been backported (with the
test)<br>
previously, see the commit
af889e4608e6eca495dd85e6161d8bcd7d3628e6<br>
("ARM64: Fix xpcall() error case (really).").<br>
<br>
Sergey Bronnikov:<br>
* added the description<br>
<br>
Part of tarantool/tarantool#12134<br>
<br>
</p>
<blockquote type="cite" cite="mid:aYwtIPtWodu_YZyz@root">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">af889e4608e6eca495dd85e6161d8bcd7d3628e6 ("ARM64: Fix xpcall()
error case (really).").
Sergey Bronnikov:
* added the description
Part of tarantool/tarantool#12134
---
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>