<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey!</p>
<p>LGTM but see the answer below</p>
<p>Sergey</p>
<div class="moz-cite-prefix">On 1/13/26 18:46, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite" cite="mid:aWZo80LA7G4uJ7g1@root">
<pre wrap="" class="moz-quote-pre">Hi, Sergey,
Thanks for the comment.
See my thoughts below.
On 13.01.26, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Hi, Sergey,
thanks for the patch! LGTM with minor comment below.
Sergey
On 12/26/25 12:18, Sergey Kaplun wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">The patch adds a script for setting the environment before running
performance tests. The script originated from the Tarantool's repository
[2]. Most of the settings are taken from the Tarantool's wiki page
dedicated to the benchmarking [1].
[1]:<a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/blob/dcdb3ee83b3d6324011e704b5a3f4ee3e19bbf47/perf/tools/setup_env.sh">https://github.com/tarantool/tarantool/blob/dcdb3ee83b3d6324011e704b5a3f4ee3e19bbf47/perf/tools/setup_env.sh</a>
[2]:<a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/wiki/Benchmarking">https://github.com/tarantool/tarantool/wiki/Benchmarking</a>
---
perf/helpers/setup_env.sh | 135 ++++++++++++++++++++++++++++++++++++++
1 file changed, 135 insertions(+)
create mode 100755 perf/helpers/setup_env.sh
diff --git a/perf/helpers/setup_env.sh b/perf/helpers/setup_env.sh
new file mode 100755
index 00000000..043d3c88
--- /dev/null
+++ b/perf/helpers/setup_env.sh
@@ -0,0 +1,135 @@
+#!/bin/sh
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">I propose to add a note to the comments that the original version of
script is in the tarantool repository.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Is it necessary?</pre>
</blockquote>
No, actually.
<blockquote type="cite" cite="mid:aWZo80LA7G4uJ7g1@root">
<pre wrap="" class="moz-quote-pre">
I'm not sure that we keep them intact since LuaJIT and Tarantool may
require different setups. Also, the origin of the file is mentioned in
the commit message.
</pre>
</blockquote>
<div class="lRu31" dir="ltr"><span class="HwtZe" lang="en"><span
class="jCAhz ChMk0b"><span class="ryNqvb">I'm afraid using
different configurations on a single computer will be
difficult.</span></span></span></div>
<div class="lRu31" dir="ltr"><span class="HwtZe" lang="en"><span
class="jCAhz ChMk0b"><span class="ryNqvb">We always use the
same OS (we don't reinstall it before each test),</span></span></span></div>
<div class="lRu31" dir="ltr"><span class="HwtZe" lang="en"><span
class="jCAhz ChMk0b"><span class="ryNqvb">and if scripts from
different projects mutate without restoring that state,</span></span></span></div>
<div class="lRu31" dir="ltr"><span class="HwtZe" lang="en"><span
class="jCAhz ChMk0b"><span class="ryNqvb">we could quickly
lose reproducibility.</span></span></span><span
class="ZSCsVd"></span>
<div class="NQSJo"><br>
</div>
</div>
<blockquote type="cite" cite="mid:aWZo80LA7G4uJ7g1@root">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">+
+# The script sets up a Linux operating system before running
+# LuaJIT benchmarks. See more details in [1].
+#
+# [1]:<a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/wiki/Benchmarking">https://github.com/tarantool/tarantool/wiki/Benchmarking</a>
+
</pre>
</blockquote>
</blockquote>
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>