<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for the patch! See my comments.</p>
<p>Sergey</p>
<div class="moz-cite-prefix">On 10/24/25 14:00, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c1b251f43807f591a5d2e4a9de4310e44d83e87a.1761301736.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">This patch introduces the `LUAJIT_BENCH_INIT` option to determine the</pre>
</blockquote>
<p>it is actually a runner for benchmark, not a command that runs
before the benchmark itself.</p>
<p>Please rephrase.</p>
<p><br>
</p>
<p>I would rename a cmake option appropriately.
LUAJIT_BENCH_EXEC/LUAJIT_BENCH_RUNNER?</p>
<p>Feel free to keep as is, I don't insist.</p>
<blockquote type="cite"
cite="mid:c1b251f43807f591a5d2e4a9de4310e44d83e87a.1761301736.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
shell command to be run before the benchmark itself. It may be useful to
set taskset, etc.
---
perf/CMakeLists.txt | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/perf/CMakeLists.txt b/perf/CMakeLists.txt
index 68e561fd..c315597f 100644
--- a/perf/CMakeLists.txt
+++ b/perf/CMakeLists.txt
@@ -7,6 +7,13 @@ if(CMAKE_BUILD_TYPE STREQUAL "Debug")
"Timings may be affected.")
endif()
+# The shell command needs to be run before benchmarks are started.
+if(LUAJIT_BENCH_INIT)
+ message(STATUS
+ "The following command will run before benchmarks: '${LUAJIT_BENCH_INIT}'."
+ )
+endif()</pre>
</blockquote>
this message is not necessary, one can see it in "ctest -V" output
<blockquote type="cite"
cite="mid:c1b251f43807f591a5d2e4a9de4310e44d83e87a.1761301736.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
+
set(PERF_OUTPUT_DIR ${PROJECT_BINARY_DIR}/perf/output)
file(MAKE_DIRECTORY ${PERF_OUTPUT_DIR})
@@ -51,7 +58,7 @@ macro(AddBench bench_name bench_path perf_suite LUA_PATH)
set(bench_out_file
${PERF_OUTPUT_DIR}/${perf_suite}/${bench_name_stripped}.json
)
- set(bench_command "${LUAJIT_BINARY} ${bench_path}")
+ set(bench_command "${LUAJIT_BENCH_INIT} ${LUAJIT_BINARY} ${bench_path}")
if(${ARGC} GREATER 4)
set(input_file ${ARGV4})
set(bench_command "${bench_command} < ${input_file}")
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>