<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for the patch! Please see my comments.</p>
<p>Sergey</p>
<div class="moz-cite-prefix">On 10/24/25 13:50, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c1cf555135cea624980a6e09c046ac6c8a70b0de.1761301736.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.
Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
perf/LuaJIT-benches/scimark-fft.lua | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/perf/LuaJIT-benches/scimark-fft.lua b/perf/LuaJIT-benches/scimark-fft.lua
index c05bb69a..96535774 100644
--- a/perf/LuaJIT-benches/scimark-fft.lua
+++ b/perf/LuaJIT-benches/scimark-fft.lua
@@ -1 +1,18 @@
-require("scimark_lib").FFT(1024)(tonumber(arg and arg[1]) or 50000)
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 50000</pre>
</blockquote>
Why 50000?
<blockquote type="cite"
cite="mid:c1cf555135cea624980a6e09c046ac6c8a70b0de.1761301736.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
+local benchmark
+benchmark = {
+ name = "scimark_fft",
+ -- XXX: The description of tests for the function is too
+ -- inconvenient.
+ skip_check = true,
+ payload = function()
+ local flops = require("scimark_lib").FFT(1024)(cycles)</pre>
</blockquote>
Why 1024?
<blockquote type="cite"
cite="mid:c1cf555135cea624980a6e09c046ac6c8a70b0de.1761301736.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
+ benchmark.items = flops
+ end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>