<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey!</p>
<p>thanks for the patch!</p>
<p>In general LGTM, I would suggest fixing the description in commit
message.</p>
<p>See below.</p>
<p>Sergey<br>
</p>
<div class="moz-cite-prefix">On 7/24/25 12:03, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:0183aa1f346bf87d8e626274323c87e2291e75bf.1753344905.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">From: Mike Pall <mike>
(cherry picked from commit 69138082a3166105faa8cbb25fadb1e4298686c0)
This patch refactors the emitting of immediates for the arm64
architecture. The main changes are the following:
* Use `emit_getgl()`, `emit_setgl()` instead of `emit_lso()`, where it
is possible, since it makes the code cleaner.
* The `RID_GL` is allocated for `g` at the start of the trace emitting.
Also, this register is considered as a candidate to be used as a base
for the N-step offset in `emit_kdelta()`.
* The address of `tmptv` is not rematerialized to the register from the
constant not. It is calculated via the adding the corresponding
offset to `RID_GL`.</pre>
</blockquote>
it is not clear for me what for hunks with `emit_dm` are needed.<br>
<p><snipped><br>
</p>
</body>
<lt-container></lt-container>
</html>