<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hello, Sergey,</p>
<p>thanks for the patch!</p>
<p>> [PATCH luajit] test: disable lj-1196 for Tarantool or
x86/x64<br>
</p>
<p>s/or/on/?<br>
</p>
<div class="moz-cite-prefix">On 7/21/25 11:16, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20250721081627.4837-1-skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">The test may lead to the assertion failure if run under Tarantool.
Also, the skip condition for the Tarantool leads to stable fails for
some builds on x86/x64 architecture, so they are skipped as well.
See details in the comment to the skip conditions.
---</pre>
</blockquote>
<p>I suppose you want to disable it temporarily, do we need an issue
as a reminder?<br>
</p>
LGTM<br>
<blockquote type="cite"
cite="mid:20250721081627.4837-1-skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool">https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool</a>
Originally I want to disable the test only for Tarantool, but faced
multiple failures in the different workflows:
<a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/actions/runs/16410069543">https://github.com/tarantool/luajit/actions/runs/16410069543</a>
.../lj-1196-partial-snap-restore.test.lua | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua b/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua
index 4ab78d31..5199ca00 100644
--- a/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua
+++ b/test/tarantool-tests/lj-1196-partial-snap-restore.test.lua
@@ -4,7 +4,14 @@ local tap = require('tap')
-- in case of the stack overflow.
-- See also: <a class="moz-txt-link-freetext" href="https://github.com/LuaJIT/LuaJIT/issues/1196">https://github.com/LuaJIT/LuaJIT/issues/1196</a>.
-local test = tap.test('lj-1196-partial-snap-restore')
+local test = tap.test('lj-1196-partial-snap-restore'):skipcond({
+ -- Disable test for Tarantool to avoid failures, see also:
+ -- <a class="moz-txt-link-freetext" href="https://github.com/LuaJIT/LuaJIT/issues/1369">https://github.com/LuaJIT/LuaJIT/issues/1369</a>.
+ ['Disabled for Tarantool due to lj-1369'] = _TARANTOOL,
+ -- Also, it may fail on some non-arm64 runners stable after
+ -- adding the skip condition above.
+ ['Disabled for x86/x64 due to lj-1369'] = jit.arch ~= 'arm64',
+})
<a class="moz-txt-link-freetext" href="test:plan(1)">test:plan(1)</a>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>