<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>LGTM<br>
</p>
<div class="moz-cite-prefix">On 7/21/25 15:29, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite" cite="mid:aH4yvX6M1PwI82Xr@root">
<pre wrap="" class="moz-quote-pre">Hi, Sergey!
Thanks for the review!
On 21.07.25, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Hello, Sergey,
thanks for the patch!
> [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64
s/or/on/?
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
No, since I've meant that either Tarantool or the corresponding arch
doesn't run this test.
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
On 7/21/25 11:16, Sergey Kaplun wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">The test may lead to the assertion failure if run under Tarantool.
Also, the skip condition for the Tarantool leads to stable fails for
some builds on x86/x64 architecture, so they are skipped as well.
See details in the comment to the skip conditions.
---
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
I suppose you want to disable it temporarily, do we need an issue as a
reminder?
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
I suppose not. It should be enabled back alongside the backporting
commit for the 1369.
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
LGTM
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
<a class="moz-txt-link-freetext" href="Branch:https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool">Branch:https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool</a>
Originally I want to disable the test only for Tarantool, but faced
multiple failures in the different workflows:
<a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/actions/runs/16410069543">https://github.com/tarantool/luajit/actions/runs/16410069543</a>
</pre>
</blockquote>
</blockquote>
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>