<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>LGTM<br>
</p>
<div class="moz-cite-prefix">On 6/6/25 18:14, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite" cite="mid:aEMF7Bna3Er0efoF@root">
<pre wrap="" class="moz-quote-pre">Hi, Sergey!
Thanks for the review!
On 06.06.25, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Hello, Sergey,
the test is passed when CMake option -DLUAJIT_USE_VALGRIND=ON is used and
patch with fix is reverted.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
You should run it with the corresponding env variable (like it is done
in the CI), see the comment in the test header:
| VALGRIND_OPTS="--track-fds=yes" ctest -V -R lj-1249
</pre>
</blockquote>
<p>It works, thanks, but the test is still passed.</p>
<p>In private conversation, we have found a reason - I have a
version of Valgrind,</p>
<p>that doesn't fail on detected fd leak:</p>
<p>Release 3.24.0 (31 Oct 2024)<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
<br>
...<br>
<br>
* ==================== CORE CHANGES ===================<br>
<br>
* Bad file descriptor usage now generates a real error with<br>
--track-fds=yes that is suppressible and shows up in the xml
output<br>
with full execution backtrace. The warnings shown without using
the<br>
option are deprecated and will be removed in a future valgrind<br>
version.<br>
</p>
<p>The same behavior is in our CI, because Valgrind 3.24.0 is in
25.04+, but in GHA the latest version is 24.04.<br>
</p>
<p>1. <a class="moz-txt-link-freetext" href="https://repology.org/project/valgrind/versions">https://repology.org/project/valgrind/versions</a></p>
<p>2.
<a class="moz-txt-link-freetext" href="https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners">https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners</a></p>
<blockquote type="cite" cite="mid:aEMF7Bna3Er0efoF@root">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
Sergey
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>