<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hello, Sergey,</p>
<p>Thanks for the patch! See my comments below.<br>
</p>
<div class="moz-cite-prefix">On 6/5/25 08:44, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c3fc5e24abd3112b5f0017d67cdec239c911d8ce.1749101434.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">This patch adds a new field, track-fds [1], in the Valgrind workflow
matrix to detect descriptor leakage in the tests.
[1]: <a class="moz-txt-link-freetext" href="https://valgrind.org/docs/manual/manual-core.html#opt.track-fds">https://valgrind.org/docs/manual/manual-core.html#opt.track-fds</a>
Needed for tarantool/tarantool#11278
---
.github/workflows/valgrind-testing.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/valgrind-testing.yaml b/.github/workflows/valgrind-testing.yaml
index e6606478..b3c7bc80 100644
--- a/.github/workflows/valgrind-testing.yaml
+++ b/.github/workflows/valgrind-testing.yaml
@@ -38,7 +38,11 @@ jobs:
# Therefore, testing on this platform is currently
# disabled.
BUILDTYPE: [Debug, Release]
- VALGRIND_SCENARIO: [full, malloc-free-fill-0x00, malloc-free-fill-0xff]
+ VALGRIND_SCENARIO:
+ - full
+ - malloc-free-fill-0x00
+ - malloc-free-fill-0xff
+ - track-fds</pre>
</blockquote>
Why we cannot add "track-fds" to the existed scenario?<br>
<blockquote type="cite"
cite="mid:c3fc5e24abd3112b5f0017d67cdec239c911d8ce.1749101434.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
include:
- BUILDTYPE: Debug
CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
@@ -59,6 +63,9 @@ jobs:
- VALGRIND_SCENARIO: malloc-free-fill-0xff
VALGRIND_OPTS: --leak-check=no --malloc-fill=0xff --free-fill=0xff
JOB_POSTFIX: "malloc/free-fill: 0xff"
+ - VALGRIND_SCENARIO: track-fds</pre>
</blockquote>
<p>According to documentation, the option "print out a list of open
file descriptors on exit or on request".</p>
<p>So the fd leak detection is semi-automated. How it should work on
CI?<br>
</p>
<blockquote type="cite"
cite="mid:c3fc5e24abd3112b5f0017d67cdec239c911d8ce.1749101434.git.skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">
+ VALGRIND_OPTS: --leak-check=no --track-fds=yes
+ JOB_POSTFIX: "track-fds"
runs-on: [self-hosted, regular, Linux, x86_64]
name: >
LuaJIT with Valgrind (Linux/x86_64)
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>