<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hello,</p>
<p>LGTM with a comment below.</p>
<p>Sergey<br>
</p>
<div class="moz-cite-prefix">On 6/6/25 16:40, Sergey Kaplun wrote:<br>
</div>
<p><snipped><br>
</p>
<blockquote type="cite" cite="mid:aELv1x5f0QmStptE@root">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">diff --git a/test/LuaJIT-tests/lang/stackov.lua b/test/LuaJIT-tests/lang/stackov.lua
index 8afa86b4..b052ad80 100644
--- a/test/LuaJIT-tests/lang/stackov.lua
+++ b/test/LuaJIT-tests/lang/stackov.lua
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">I don't get why we need this change. With reverted patch this test is
passed.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
With reverted -- yes. But after reworking the stack overflow handling,
it is possible that there is no place on the stack to call the error
handler (in that case, `debug.traceback`). Since this thing looks like
implementation-defined behaviour, I prefer to make the test less strict.
</pre>
</blockquote>
Please add a message to the test or/and to the commit message.<br>
<blockquote type="cite" cite="mid:aELv1x5f0QmStptE@root">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">@@ -31,13 +31,17 @@ end
do --- Base test.
local err, s = xpcall(f, debug.traceback)
assert(err == false)
- test_error_msg(f, s)
+ -- There is no place on the stack to invoke the handler.
+ -- Just test the error reason.
+ assert(string.match(s, "stack overflow"))
end
do --- Stack overflow with non-empty arg list.
local err, s = xpcall(g, debug.traceback, 1)
assert(err == false)
- test_error_msg(g, s)
+ -- There is no place on the stack to invoke the handler.
+ -- Just test the error reason.
+ assert(string.match(s, "stack overflow"))
end
do --- Vararg tail call with non-empty arg list. +slow
</pre>
</blockquote>
</blockquote>
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>