<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for the patch!</p>
<p>LGTM and in a private conversation we decided to document</p>
<p>all steps required for managing branches in repository somewhere.
I believe</p>
<p>it will help us to reduce a probability of mistakes like wrong
`tarantool_revision`</p>
<p>in release branch.<br>
</p>
<p>Sergey<br>
</p>
<div class="moz-cite-prefix">On 5/30/25 15:12, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20250530121233.13591-1-skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">This patch adds the specific Tarantool revision to be checked out in
callee workflows to avoid the inconsistency between the used workflow
and the version of Tarantool that ref we are using. This revision should
be updated during the bump of the workflow to the corresponding
long-term branch.
The patch left the <testing.yml> workflow intact since it uses a
different approach.
---
Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/skaplun/tarantool-integration-branch-revision">https://github.com/tarantool/luajit/tree/skaplun/tarantool-integration-branch-revision</a>
.github/workflows/integration-tarantool-ecosystem.yml | 1 +
.github/workflows/integration-tarantool.yml | 11 +++++++++++
2 files changed, 12 insertions(+)
diff --git a/.github/workflows/integration-tarantool-ecosystem.yml b/.github/workflows/integration-tarantool-ecosystem.yml
index e303ae32..7b37bf86 100644
--- a/.github/workflows/integration-tarantool-ecosystem.yml
+++ b/.github/workflows/integration-tarantool-ecosystem.yml
@@ -43,3 +43,4 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
diff --git a/.github/workflows/integration-tarantool.yml b/.github/workflows/integration-tarantool.yml
index 86182dd3..3d6deb6e 100644
--- a/.github/workflows/integration-tarantool.yml
+++ b/.github/workflows/integration-tarantool.yml
@@ -39,6 +39,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-debug:
name: debug
@@ -46,6 +47,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-debug_aarch64:
name: debug aarch64
@@ -53,6 +55,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-debug_asan_clang:
name: debug ASAN clang
@@ -60,6 +63,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-out_of_source:
name: out of source
@@ -67,6 +71,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release:
name: release
@@ -74,6 +79,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_asan_clang:
name: release ASAN clang
@@ -81,6 +87,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_clang:
name: release clang
@@ -88,6 +95,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_lto:
name: release lto
@@ -95,6 +103,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-release_lto_clang:
name: release lto clang
@@ -102,6 +111,7 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
test-tarantool-static_build:
name: static build
@@ -109,3 +119,4 @@ jobs:
with:
submodule: luajit
revision: ${{ github.sha }}
+ tarantool_revision: master
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>