<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for the patch! LGTM<br>
</p>
<div class="moz-cite-prefix">On 5/14/25 12:38, Sergey Kaplun wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20250514093826.31470-1-skaplun@tarantool.org">
<pre wrap="" class="moz-quote-pre">This patch fixes the flake8 warning F824 [1]:
| F824 `global gtype_cache` is unused: name is never assigned in scope
This patch removes the `global` definition inside the function since,
according to [2], it's already considered global.
[1]: <a class="moz-txt-link-freetext" href="https://flake8.pycqa.org/en/latest/user/error-codes.html">https://flake8.pycqa.org/en/latest/user/error-codes.html</a>
[2]: <a class="moz-txt-link-freetext" href="https://docs.python.org/3/faq/programming.html#what-are-the-rules-for-local-and-global-variables-in-python">https://docs.python.org/3/faq/programming.html#what-are-the-rules-for-local-and-global-variables-in-python</a>
---
Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/skaplun/fix-flake8-7.2.0">https://github.com/tarantool/luajit/tree/skaplun/fix-flake8-7.2.0</a>
The workflow isn't updated since this version of flake8 is unavailable
for the python 3.8. OTOH, action/setup-python shouldn't be run on
self-hosted runners, see [3].
[3]: <a class="moz-txt-link-freetext" href="https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#using-setup-python-with-a-self-hosted-runner">https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#using-setup-python-with-a-self-hosted-runner</a>
src/luajit-gdb.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
index d2070e9b..0ae2a6e0 100644
--- a/src/luajit-gdb.py
+++ b/src/luajit-gdb.py
@@ -23,7 +23,6 @@ gtype_cache = {}
def gtype(typestr):
- global gtype_cache
if typestr in gtype_cache:
return gtype_cache[typestr]
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>