<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Thanks! LGTM<br>
</p>
<div class="moz-cite-prefix">On 11.03.2025 15:37, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:Z9AueLaSoDSruQJz@root">
<pre wrap="" class="moz-quote-pre">Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.
On 11.03.25, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Hi, Sergey,
thanks for the patch! LGTM with a minor comment below.
Sergey
On 10.03.2025 17:51, Sergey Kaplun wrote:
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">+local bigstr = string.rep('x', ALLOC_LIMIT)
+local __concat = function()
+ return 'concated'
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">s/concated/concatenated/
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Fixed, thanks:
===================================================================
diff --git a/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua b/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua
index 961df798..20d93c43 100644
--- a/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua
+++ b/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua
@@ -20,7 +20,7 @@ local ALLOC_LIMIT = 2048
local bigstr = string.rep('x', ALLOC_LIMIT)
local __concat = function()
- return 'concated'
+ return 'concatenated'
end
-- Need to use metamethod call in the concat recording.
===================================================================
I've also checked that this is not ruined the testcase.
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>