<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,<br>
</p>
<div class="moz-cite-prefix">On 05.03.2025 18:12, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:Z8hp6VfWnS-IIXp3@root">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre"><snipped>
+ res, err = misc.memprof.stop()
-- Want to cleanup carefully if something went wrong.
if not res then
+ <a class="moz-txt-link-freetext" href="test:fail('sysprof">test:fail('sysprof</a> was not started: ' .. err)
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Looks like it should be: "was not stopped successfully".
</pre>
</blockquote>
<p>Fixed, thanks!</p>
<p>---
a/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua<br>
+++
b/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua<br>
@@ -26,7 +26,7 @@ <a class="moz-txt-link-freetext" href="test:test('default-output-file">test:test('default-output-file</a>',
function(subtest)<br>
res, err = misc.memprof.stop()<br>
-- Want to cleanup carefully if something went wrong.<br>
if not res then<br>
- <a class="moz-txt-link-freetext" href="test:fail('sysprof">test:fail('sysprof</a> was not started: ' .. err)<br>
+ <a class="moz-txt-link-freetext" href="test:fail('sysprof">test:fail('sysprof</a> was not stopped: ' .. err)<br>
os.remove(default_output_file)<br>
end<br>
<br>
</p>
<blockquote type="cite" cite="mid:Z8hp6VfWnS-IIXp3@root">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre"> os.remove(default_output_file)
- error(err)
end
+
local profile_buf = tools.read_file(default_output_file)
<a class="moz-txt-link-freetext" href="subtest:ok(profile_buf">subtest:ok(profile_buf</a> ~= nil and #profile_buf ~= 0,
'default output file is not empty')
- -- We don't need it any more.
+ -- We don't need it anymore.
os.remove(default_output_file)
end)
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>